This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
[HIVEMALL-109][HIVEMALL-112] Fix topic model and tokenize UDFs #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and validate it as unit test
Since now iteration works correctly, manual for-loops are removed from unit tests.
|
^ CI failed due to inappropriate hyper-parameters in unit tests. Will fix sooner. |
1 similar comment
myui
reviewed
Jun 6, 2017
| @@ -554,6 +546,21 @@ protected void forwardModel() throws HiveException { | |||
| */ | |||
|
|
|||
| @VisibleForTesting | |||
| public void closeWithoutModelReset() throws HiveException { | |||
There was a problem hiding this comment.
should be default scope for VisibleForTesting.
| @@ -452,7 +447,7 @@ protected final void runIterativeTraining(@Nonnegative final int iterations) | |||
| } | |||
| while (remain >= SizeOf.INT) { | |||
| int pos = buf.position(); | |||
| int recordBytes = buf.getInt(); | |||
| int recordBytes = buf.getInt() - SizeOf.INT; | |||
asfgit
pushed a commit
that referenced
this pull request
Jun 6, 2017
|
Merged with some modifications. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#82
train_plsaandtrain_ldarecordBytescalculation for iteration utilizing file IOtokenize()What type of PR is it?
Bug Fix
What is the Jira issue?
How was this patch tested?