Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

feat: support managing heartbeat #12

Merged
merged 5 commits into from
Jul 7, 2022
Merged

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Jul 6, 2022

Which issue does this PR close?

Part of work of #10

Rationale for this change

The heartbeat stream from clients needs management by HeartbeatStreams including Bind, Unbind etc.

What changes are included in this PR?

Introduce the HeartbeatStreams to manage heartbeat streams from clients.

Are there any user-facing changes?

How does this change test

@ShiKaiWi ShiKaiWi mentioned this pull request Jul 6, 2022
3 tasks
server/grpcservice/service.go Show resolved Hide resolved
server/grpcservice/service.go Outdated Show resolved Hide resolved
server/grpcservice/service.go Outdated Show resolved Hide resolved
@ShiKaiWi ShiKaiWi changed the title feat: Support managing heartbeat feat: support managing heartbeat Jul 7, 2022
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit ff07d61 into apache:main Jul 7, 2022
@ShiKaiWi ShiKaiWi deleted the feat-handle-hb branch July 7, 2022 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants