Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

test: fix test update cluster view #204

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

ZuLiangWang
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Fix broken unit test.

What changes are included in this PR?

  • Fix testUpdateClusterView

Are there any user-facing changes?

None.

How does this change test

Pass all unit tests and integration test.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #204 (64bdb53) into main (7f1354e) will increase coverage by 20.68%.
The diff coverage is 55.81%.

@@             Coverage Diff             @@
##             main     #204       +/-   ##
===========================================
+ Coverage   39.66%   60.34%   +20.68%     
===========================================
  Files          34       41        +7     
  Lines        4213     4918      +705     
===========================================
+ Hits         1671     2968     +1297     
+ Misses       2317     1570      -747     
- Partials      225      380      +155     
Impacted Files Coverage Δ
pkg/coderr/code.go 0.00% <ø> (ø)
server/cluster/metadata/types.go 0.00% <0.00%> (ø)
server/coordinator/procedure/util.go 0.00% <ø> (ø)
server/storage/meta.go 0.00% <ø> (ø)
server/storage/storage_impl.go 57.21% <0.00%> (-5.10%) ⬇️
server/member/watch_leader.go 40.62% <20.00%> (-2.71%) ⬇️
server/cluster/manager.go 39.02% <23.07%> (ø)
server/member/member.go 47.39% <45.00%> (-1.32%) ⬇️
server/coordinator/scheduler/scheduler_manager.go 53.96% <47.36%> (ø)
server/coordinator/procedure/manager_impl.go 73.68% <55.55%> (+73.68%) ⬆️
... and 13 more

... and 3 files with indirect coverage changes

Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit d7ae6ee into apache:main Jun 26, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants