Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

fix: drop partition table #231

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

ZuLiangWang
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Fixed the issue where the table could not be deleted normally when the shard mapping relationship of the table did not exist.

What changes are included in this PR?

  • Modified the logic about drop table.
  • Add some logs to facilitate troubleshooting.

Are there any user-facing changes?

None.

How does this change test

Pass all unit tests and integration test.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #231 (dee6507) into main (7f1354e) will increase coverage by 20.89%.
Report is 34 commits behind head on main.
The diff coverage is 60.84%.

@@             Coverage Diff             @@
##             main     #231       +/-   ##
===========================================
+ Coverage   39.66%   60.55%   +20.89%     
===========================================
  Files          34       43        +9     
  Lines        4213     5395     +1182     
===========================================
+ Hits         1671     3267     +1596     
+ Misses       2317     1716      -601     
- Partials      225      412      +187     
Files Changed Coverage Δ
pkg/coderr/code.go 0.00% <ø> (ø)
server/cluster/metadata/types.go 0.00% <0.00%> (ø)
server/coordinator/procedure/util.go 0.00% <ø> (ø)
server/storage/meta.go 0.00% <ø> (ø)
server/storage/storage_impl.go 57.21% <0.00%> (-5.10%) ⬇️
...ure/ddl/droppartitiontable/drop_partition_table.go 47.92% <17.39%> (-2.82%) ⬇️
server/member/watch_leader.go 40.62% <20.00%> (-2.71%) ⬇️
server/cluster/manager.go 38.96% <23.18%> (ø)
server/coordinator/factory.go 76.68% <30.76%> (+72.22%) ⬆️
.../operation/transferleader/batch_transfer_leader.go 33.80% <33.80%> (ø)
... and 22 more

... and 1 file with indirect coverage changes

@ZuLiangWang ZuLiangWang force-pushed the fix_drop_patition_table_0914 branch 2 times, most recently from 221633f to 297033c Compare September 15, 2023 06:34
server/cluster/metadata/cluster_metadata.go Outdated Show resolved Hide resolved
server/cluster/metadata/cluster_metadata.go Outdated Show resolved Hide resolved
server/coordinator/procedure/ddl/common_util.go Outdated Show resolved Hide resolved
server/coordinator/procedure/ddl/common_util.go Outdated Show resolved Hide resolved
server/coordinator/procedure/ddl/droptable/drop_table.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/service/grpc/service.go Outdated Show resolved Hide resolved
server/service/grpc/service.go Show resolved Hide resolved
server/service/grpc/service.go Show resolved Hide resolved
@ShiKaiWi ShiKaiWi changed the title fix: fix drop partition table fix: drop partition table Sep 19, 2023
@ZuLiangWang ZuLiangWang merged commit b397c74 into apache:main Sep 20, 2023
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants