Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

feat: add procedure manager #72

Merged
merged 21 commits into from
Oct 20, 2022
Merged

feat: add procedure manager #72

merged 21 commits into from
Oct 20, 2022

Conversation

ZuLiangWang
Copy link
Contributor

@ZuLiangWang ZuLiangWang commented Oct 12, 2022

Which issue does this PR close?

Close #70

Rationale for this change

As mentioned in issue, add a procedure manager implementation

What changes are included in this PR?

  • Delete NewProcedure func in procedure.go
  • Add Manager interface in manager.go
  • Implement submitretrycancel func

Are there any user-facing changes?

None.

How does this change test

Pass unit test.

server/coordinator/procedure/manager.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager.go Outdated Show resolved Hide resolved
server/cluster/manager.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/cluster/manager.go Outdated Show resolved Hide resolved
server/cluster/manager.go Outdated Show resolved Hide resolved
server/cluster/manager.go Outdated Show resolved Hide resolved
server/coordinator/procedure/factory.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Show resolved Hide resolved
server/coordinator/procedure/storage.go Show resolved Hide resolved
server/coordinator/procedure/factory.go Outdated Show resolved Hide resolved
server/coordinator/procedure/factory.go Outdated Show resolved Hide resolved
server/coordinator/procedure/factory.go Outdated Show resolved Hide resolved
server/coordinator/procedure/factory.go Outdated Show resolved Hide resolved
server/coordinator/procedure/factory.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/factory.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
server/coordinator/procedure/manager_impl.go Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 0fe490d into apache:main Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add procedure manager to maintain procedure
3 participants