This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunshao90
reviewed
Oct 12, 2022
ZuLiangWang
force-pushed
the
manager
branch
3 times, most recently
from
October 17, 2022 06:52
dca4bd7
to
156d7fd
Compare
ShiKaiWi
reviewed
Oct 17, 2022
chunshao90
reviewed
Oct 19, 2022
chunshao90
reviewed
Oct 19, 2022
ShiKaiWi
reviewed
Oct 19, 2022
ShiKaiWi
reviewed
Oct 19, 2022
ShiKaiWi
reviewed
Oct 20, 2022
ZuLiangWang
force-pushed
the
manager
branch
2 times, most recently
from
October 20, 2022 12:04
3ca4126
to
eed8977
Compare
ShiKaiWi
reviewed
Oct 20, 2022
ShiKaiWi
reviewed
Oct 20, 2022
ShiKaiWi
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Close #70
Rationale for this change
As mentioned in issue, add a procedure manager implementation
What changes are included in this PR?
NewProcedure
func in procedure.goManager
interface in manager.gosubmit
、retry
、cancel
funcAre there any user-facing changes?
None.
How does this change test
Pass unit test.