Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve ci config #136

Merged
merged 3 commits into from
Nov 4, 2021
Merged

improve ci config #136

merged 3 commits into from
Nov 4, 2021

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Oct 29, 2021

No description provided.

javeme
javeme reviewed Oct 29, 2021
View reviewed changes
computer-test/src/main/java/com/baidu/hugegraph/computer/suite/unit/UnitTestSuite.java Outdated
Whitebox.setInternalState(ComputerOptions.OUTPUT_HDFS_URL,
"defaultValue", "hdfs://127.0.0.1:9000");
Whitebox.setInternalState(ComputerOptions.OUTPUT_HDFS_USER,
"defaultValue", System.getProperty("user.name"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exceed 80 chars

@codecov
Copy link

codecov bot commented Oct 29, 2021 •
edited
Loading

Codecov Report

Merging #136 (ebf5a5f) into master (b8db9f8) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
+ Coverage     88.03%   88.16%   +0.12%     
- Complexity     2881     2886       +5     
============================================
  Files           303      303              
  Lines         10868    10866       -2     
  Branches        913      912       -1     
============================================
+ Hits           9568     9580      +12     
+ Misses          865      852      -13     
+ Partials        435      434       -1
Impacted Files Coverage Δ
...ugegraph/computer/core/compute/ComputeManager.java 86.84% <0.00%> (-0.82%) ⬇️
...aidu/hugegraph/computer/core/graph/id/BytesId.java 81.48% <0.00%> (-0.80%) ⬇️
...raph/computer/core/compute/FileGraphPartition.java 86.97% <0.00%> (+0.52%) ⬆️
...k8s/operator/controller/ComputerJobController.java 89.13% <0.00%> (+1.44%) ⬆️
...om/baidu/hugegraph/computer/k8s/util/KubeUtil.java 91.89% <0.00%> (+1.80%) ⬆️
...mputer/k8s/operator/common/AbstractController.java 84.34% <0.00%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8db9f8...ebf5a5f. Read the comment docs.

@coderzc coderzc requested a review from javeme November 4, 2021 02:27
javeme
javeme previously approved these changes Nov 4, 2021
View reviewed changes
imbajin
imbajin approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add more ci update later (stable)

@coderzc coderzc merged commit 1d45f5d into master Nov 4, 2021
@imbajin imbajin deleted the improve-ci-config branch November 4, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javeme javeme javeme approved these changes

@imbajin imbajin imbajin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderzc @javeme @imbajin