Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump httpclient from 4.5.2 to 4.5.13 #1487

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 4, 2021

Bumps httpclient from 4.5.2 to 4.5.13.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Incompatible dependencies of package label Jun 4, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

@javeme
Copy link
Contributor

javeme commented Dec 21, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.httpcomponents-httpclient-4.5.13 branch from b79adf8 to 9445140 Compare December 21, 2021 03:58
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #1487 (087493d) into master (47aa1c9) will increase coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1487      +/-   ##
============================================
+ Coverage     66.76%   67.15%   +0.38%     
- Complexity     7068     7089      +21     
============================================
  Files           420      420              
  Lines         34731    34731              
  Branches       4822     4822              
============================================
+ Hits          23189    23322     +133     
+ Misses         9205     9069     -136     
- Partials       2337     2340       +3     
Impacted Files Coverage Δ
...va/com/baidu/hugegraph/auth/HugeAuthenticator.java 34.78% <0.00%> (-5.44%) ⬇️
...in/java/com/baidu/hugegraph/auth/HugeResource.java 77.92% <0.00%> (-1.30%) ⬇️
.../java/com/baidu/hugegraph/auth/RolePermission.java 90.58% <0.00%> (-1.18%) ⬇️
...a/com/baidu/hugegraph/backend/query/Condition.java 79.42% <0.00%> (-0.37%) ⬇️
.../baidu/hugegraph/backend/query/ConditionQuery.java 85.94% <0.00%> (+0.26%) ⬆️
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 72.30% <0.00%> (+0.30%) ⬆️
.../backend/store/cassandra/CassandraSessionPool.java 57.14% <0.00%> (+1.02%) ⬆️
...ain/java/com/baidu/hugegraph/task/TaskManager.java 70.50% <0.00%> (+1.43%) ⬆️
...egraph/backend/store/cassandra/CassandraShard.java 52.77% <0.00%> (+1.85%) ⬆️
...va/com/baidu/hugegraph/task/ServerInfoManager.java 74.15% <0.00%> (+2.80%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47aa1c9...087493d. Read the comment docs.

javeme
javeme previously approved these changes Dec 21, 2021
zhoney
zhoney previously approved these changes Dec 21, 2021
@imbajin
Copy link
Member

imbajin commented Dec 21, 2021

seems PG'/Mysqls ci always failed (after retry 4 times)

consider don't merge it now

@javeme
Copy link
Contributor

javeme commented Dec 21, 2021

The CI error may be caused by URIBuilder

Error:  Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.345 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
Error:  com.baidu.hugegraph.core.CoreTestSuite  Time elapsed: 2.344 s  <<< ERROR!
com.baidu.hugegraph.exception.ConnectionException: Failed to connect to MySQL
	at com.baidu.hugegraph.core.CoreTestSuite.init(CoreTestSuite.java:68)
Caused by: java.sql.SQLException: No suitable driver found for /jdbc:postgresql://localhost:5432/hugegraph?loggerLevel=OFF&useSSL=false&characterEncoding=utf-8&rewriteBatchedStatements=true&useServerPrepStmts=false&autoReconnect=false&maxReconnects=3&initialTimeout=3
	at com.baidu.hugegraph.core.CoreTestSuite.init(CoreTestSuite.java:68)

Error:  com.baidu.hugegraph.core.CoreTestSuite  Time elapsed: 2.345 s  <<< ERROR!
com.baidu.hugegraph.exception.ConnectionException: Failed to connect to MySQL
	at com.baidu.hugegraph.core.CoreTestSuite.clear(CoreTestSuite.java:80)
Caused by: java.sql.SQLException: No suitable driver found for /jdbc:postgresql://localhost:5432/hugegraph?loggerLevel=OFF&useSSL=false&characterEncoding=utf-8&rewriteBatchedStatements=true&useServerPrepStmts=false&autoReconnect=false&maxReconnects=3&initialTimeout=3
	at com.baidu.hugegraph.core.CoreTestSuite.clear(CoreTestSuite.java:80)

expect:

'jdbc:postgresql://localhost:5432/hugegraph?loggerLevel=OFF&useSSL=false&characterEncoding=utf-8&rewriteBatchedStatements=true&useServerPrepStmts=false&autoReconnect=false&maxReconnects=3&initialTimeout=3'

but got:

'/jdbc:postgresql://localhost:5432/hugegraph?loggerLevel=OFF&useSSL=false&characterEncoding=utf-8&rewriteBatchedStatements=true&useServerPrepStmts=false&autoReconnect=false&maxReconnects=3&initialTimeout=3'

URIBuilder changes:
apache/httpcomponents-client@4a976e1#diff-8ff031403b79921a30cc33953ade4beb01bb432afeda0ca840bf495693ebb151R275

javeme referenced this pull request Dec 21, 2021
also fix added leading "/" into url by URIBuilder:
https://github.com/hugegraph/hugegraph/pull/1487#issuecomment-998749310

Change-Id: I71aa4f75bf53fd3841f51856af3df85169b37d66
@javeme javeme closed this Dec 21, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 21, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@javeme javeme deleted the dependabot/maven/org.apache.httpcomponents-httpclient-4.5.13 branch December 21, 2021 17:09
coderzc referenced this pull request Dec 22, 2021
also fix added leading "/" into url by URIBuilder:
https://github.com/hugegraph/hugegraph/pull/1487#issuecomment-998749310

Change-Id: I71aa4f75bf53fd3841f51856af3df85169b37d66
@javeme javeme restored the dependabot/maven/org.apache.httpcomponents-httpclient-4.5.13 branch December 22, 2021 07:55
@javeme javeme reopened this Dec 22, 2021
Bumps httpclient from 4.5.2 to 4.5.13.

---
updated-dependencies:
- dependency-name: org.apache.httpcomponents:httpclient
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot dismissed stale reviews from zhoney and javeme via 087493d December 22, 2021 07:55
@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.httpcomponents-httpclient-4.5.13 branch from 9445140 to 087493d Compare December 22, 2021 07:55
@javeme
Copy link
Contributor

javeme commented Dec 22, 2021

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 22, 2021

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@javeme javeme merged commit ece4c5a into master Dec 22, 2021
@javeme javeme deleted the dependabot/maven/org.apache.httpcomponents-httpclient-4.5.13 branch December 22, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Incompatible dependencies of package inactive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants