refact(auth): cache login role in auth client to avoid sending rpc repeatedly #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbajin
force-pushed
the
cache-auth-client
branch
from
baef87f
to
e6452b5
Compare
javeme
requested changes
Jun 18, 2021
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/StandardAuthenticator.java
Show resolved
Hide resolved
Comment on lines
142
to
147
| Id usrname = IdGenerator.of(username); | ||
| UserRoleCache userRole = this.usersRoleCache.getOrFetch(usrname, r -> { | ||
| RolePermission rolePermission = this.graph().authManager() | ||
| .loginUser(username, password); | ||
| return new UserRoleCache(rolePermission, password); | ||
| }); |
There was a problem hiding this comment.
prefer to move to hugegraph auth proxy
imbajin
force-pushed
the
cache-auth-client
branch
from
e6452b5
to
bdb9ca4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1507 +/- ##
============================================
+ Coverage 59.63% 59.67% +0.04%
- Complexity 6147 6151 +4
============================================
Files 410 410
Lines 33222 33255 +33
Branches 4588 4591 +3
============================================
+ Hits 19812 19846 +34
+ Misses 11343 11335 -8
- Partials 2067 2074 +7
Continue to review full report at Codecov.
|
imbajin
force-pushed
the
cache-auth-client
branch
from
bdb9ca4
to
4b816b6
Compare
Also enhance: - add time strategy to avoid old logs overwriting by current logs - auto create log folder if it does not exist - add some comment for auth config * use strict mode for config property & separate rest configs * reduce log format length * Update rest-server.properties * update all configs (TODO: push to other modules)
…peatedly TODO: also need be compatible with token way (consider put 'usrname + passwd' together into caches's key)
imbajin
force-pushed
the
cache-auth-client
branch
from
92625e9
to
87979ac
Compare
javeme
reviewed
Jun 23, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/config/CoreOptions.java
Outdated
Show resolved
Hide resolved
imbajin
force-pushed
the
cache-auth-client
branch
from
ee060d0
to
9b93511
Compare
javeme
requested changes
Jun 24, 2021
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/StandardAuthenticator.java
Show resolved
Hide resolved
…peatedly fix: don't create Id every time perf: remove useless toLowerCase add config for expire time in auth client
…graph into cache-auth-client
javeme
reviewed
Jun 25, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/config/AuthOptions.java
Outdated
Show resolved
Hide resolved
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
Jun 25, 2021
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/config/AuthOptions.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/config/AuthOptions.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/config/AuthOptions.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/auth/StandardAuthManager.java
Show resolved
Hide resolved
javeme
reviewed
Jun 25, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/auth/StandardAuthManager.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/auth/StandardAuthManager.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
Jun 25, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/auth/StandardAuthManager.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
Jun 25, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/auth/StandardAuthManager.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/auth/StandardAuthManager.java
Outdated
Show resolved
Hide resolved
javeme
approved these changes
Jun 25, 2021
Linary
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before cache:
after cache in auth client:
