Support uuid id type #618
Merged
Support uuid id type #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
============================================
- Coverage 71.89% 70.98% -0.91%
+ Complexity 3615 3574 -41
============================================
Files 218 219 +1
Lines 16802 16882 +80
Branches 2389 2399 +10
============================================
- Hits 12079 11983 -96
- Misses 3467 3630 +163
- Partials 1256 1269 +13
Continue to review full report at Codecov.
|
javeme
force-pushed
the
support-uuid
branch
2 times, most recently
from
d5ce26d
to
59c4fae
Compare
zhoney
requested changes
Jul 24, 2019
| @@ -143,6 +143,7 @@ public static void loadSchema(final HugeGraph graph) { | |||
| schema.vertexLabel("reviewer").properties("name", "timestamp") | |||
| .primaryKeys("name").create(); | |||
|
|
|||
|
|
|||
| @@ -744,6 +743,75 @@ public void testAddVertexWithCustomizeNumberIdStrategyWithoutValidId() { | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testAddVertexWithCustomizeUuidStrategy() { | |||
There was a problem hiding this comment.
testAddVertexWithCustomizeUuidIdStrategy()
| } | ||
|
|
||
| @Test | ||
| public void testAddVertexWithCustomizeUuidStrategyWithoutValidId() { |
| @@ -318,6 +326,7 @@ public BytesBuffer writeId(Id id, boolean big) { | |||
| len -= 1; | |||
| int high = len >> 8; | |||
| int low = len & 0xff; | |||
| assert high != 0x7f; // The tail 7 bits 1 reserved for UUID | |||
There was a problem hiding this comment.
'len <= BIG_ID_MAX_LEN' can't ensure 'high != 0x7f',
There was a problem hiding this comment.
id len must be in range [0, 126]
| public static final int ID_MAX_LEN = UINT8_MAX & 0x7f + 1; // 128 | ||
| public static final int BIG_ID_MAX_LEN = UINT16_MAX & 0x7fff + 1; // 32768 | ||
| public static final int ID_MAX_LEN = UINT8_MAX & 0x7f; // 127 | ||
| public static final int BIG_ID_MAX_LEN = UINT16_MAX & 0x7fff; // 32767 |
There was a problem hiding this comment.
yes, 1byte id len must be in range [0, fe], 2byte id len must be in range [0, feff]
There was a problem hiding this comment.
sorry, 1byte id len must be in range [0, 7e], 2byte id len must be in range [0, 7eff]
implement #617 Change-Id: Ie05d7a3609dd1695728f0a2f4a322448ac8aabeb
Change-Id: Ia8046307813f21104c35e74afcb36cff2e3694dc
Change-Id: I0174d1ace1f193124cc37f4f1689ca087b91f525
Change-Id: I6f45a5a709fad866642073ddeb231b7500acf902
Linary
requested changes
Jul 30, 2019
| } | ||
|
|
||
| public enum IdType { | ||
| UNKONW, |
There was a problem hiding this comment.
spell error UNKONW -> UNKNOWN
| return of(LongEncoding.decode(id)); | ||
| case UUID: | ||
| byte[] bytes = Base64.getDecoder().decode(id); | ||
| return of(bytes, type); |
There was a problem hiding this comment.
just return of(bytes, UUID);
zhoney
approved these changes
Jul 30, 2019
Linary
approved these changes
Jul 30, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement #617
Change-Id: Ie05d7a3609dd1695728f0a2f4a322448ac8aabeb