Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uuid serialize #694

Merged
merged 5 commits into from
Sep 27, 2019
Merged

fix uuid serialize #694

merged 5 commits into from
Sep 27, 2019

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Sep 22, 2019

implement: #618
Change-Id: I4615dacacdc818302563e11bd58c616a3b1cef03

@codecov
Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #694 into master will decrease coverage by 0.67%.
The diff coverage is 76.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #694      +/-   ##
============================================
- Coverage     74.31%   73.64%   -0.68%     
+ Complexity     4090     4075      -15     
============================================
  Files           220      220              
  Lines         17918    17928      +10     
  Branches       2571     2573       +2     
============================================
- Hits          13316    13203     -113     
- Misses         3247     3373     +126     
+ Partials       1355     1352       -3
Impacted Files Coverage Δ Complexity Δ
...u/hugegraph/schema/builder/VertexLabelBuilder.java 87.06% <ø> (ø) 65 <0> (ø) ⬇️
...n/java/com/baidu/hugegraph/schema/VertexLabel.java 100% <ø> (ø) 8 <0> (ø) ⬇️
...java/com/baidu/hugegraph/type/define/DataType.java 85.33% <100%> (ø) 38 <0> (ø) ⬇️
...va/com/baidu/hugegraph/backend/id/IdGenerator.java 82.2% <50%> (-1.67%) 19 <0> (ø)
...idu/hugegraph/backend/id/SnowflakeIdGenerator.java 65.51% <50%> (ø) 7 <0> (ø) ⬇️
...c/main/java/com/baidu/hugegraph/util/JsonUtil.java 60.41% <62.5%> (-3.74%) 6 <0> (ø)
...ava/com/baidu/hugegraph/io/HugeGraphSONModule.java 70.18% <78.12%> (+8.18%) 6 <5> (+3) ⬆️
.../java/com/baidu/hugegraph/util/StringEncoding.java 81.66% <90%> (+1.66%) 20 <4> (+4) ⬆️
...graph/backend/store/scylladb/ScyllaDBFeatures.java 0% <0%> (-100%) 0% <0%> (-3%)
...h/backend/store/scylladb/ScyllaDBTablesWithMV.java 0% <0%> (-84.16%) 0% <0%> (-10%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8ceb4...e8e8393. Read the comment docs.

@@ -11,7 +11,10 @@ scriptEngines: {
com.baidu.hugegraph.plugin.HugeGraphGremlinPlugin: {},
org.apache.tinkerpop.gremlin.server.jsr223.GremlinServerGremlinPlugin: {},
org.apache.tinkerpop.gremlin.jsr223.ImportGremlinPlugin: {
classImports: [java.lang.Math, com.baidu.hugegraph.util.DateUtil],
classImports: [java.lang.Math,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to next line

Change-Id: I4615dacacdc818302563e11bd58c616a3b1cef03
Change-Id: Ib0df177c06ade3c1d5e3afa5cc11f74bdea71e90
Change-Id: I7c2fb1e08a69860bd0644d7f8d1206f64e049a5c
Change-Id: Iac4a153393dfacdca696929b8e74145fe3ada4be
Change-Id: I435e4ce14388d0fa9359cb476d0d5fe75b3075dd
@zhoney zhoney merged commit 3ef07e0 into master Sep 27, 2019
@zhoney zhoney deleted the uuid-bug branch September 27, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants