This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
[KOGITO-748] - Renaming to kogito-operator #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardozanini
commented
Dec 10, 2019
containers: | ||
- name: kogito-cloud-operator | ||
- name: kogito-operator | ||
image: quay.io/kiegroup/kogito-cloud-operator:0.6.0 | ||
command: | ||
- kogito-cloud-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't change since the build script generates the final binary with the name of the repository, plus won't have a major change in the image.
ricardozanini
force-pushed
the
kogito-748
branch
from
December 10, 2019 20:35
8f26ceb
to
01c0f69
Compare
spolti
approved these changes
Dec 10, 2019
ricardozanini
added
on hold ✋
Pull Request is waiting for other dependencies
and removed
needs review 🔍
Pull Request that needs reviewers
labels
Dec 10, 2019
Waiting for this PR to pass all checks: |
radtriste
approved these changes
Dec 11, 2019
sutaakar
approved these changes
Dec 11, 2019
ricardozanini
force-pushed
the
kogito-748
branch
from
December 13, 2019 15:18
01c0f69
to
7e43b9b
Compare
ricardozanini
removed
the
on hold ✋
Pull Request is waiting for other dependencies
label
Dec 13, 2019
PR from hub merged, let's merge this also and launch CLI |
ricardozanini
added a commit
to ricardozanini/incubator-kie-kogito-operator
that referenced
this pull request
Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
https://issues.redhat.com/browse/KOGITO-748
This is needed because of:
operator-framework/community-operators#980 (comment)
Quay doesn't let us to have
kogito-cloud-operator
for application and repository, thus I created thekogito-operator
application to handle the hub manifest and rebranded everything else, except our repository.After merging this, I'll re upload the CLI based on 0.6.x branch.
Many thanks for submiting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[KOGITO-XYZ] Subject