FAI-105: Embed kogito-tooling editors in trusty-ai #142

manstis · 2020-04-28T16:07:39Z

See https://issues.redhat.com/browse/FAI-105

Hi @tiagobento @ederign this is my first pass at making a generic embeddable editor for kogito-tooling. Most of it will look very familiar to you (as I see the envelope etc is copy and pasted across the different channels already). index.tsx (the non-envelope version) and KogitoEditorWrapper are the real points of interest to demonstrate a generic embedded use case.

I do have a problem with a forward reference to the real editor to get it's content (if you run this you'll see there are two buttons to the content; one is external to the embedded editor the other is internal. The external form does not run anything.. IDK why, any ideas?)

All existing channels use the internal form to get the editors' content and perform a save.

Trusty does not need to get the content and would set the readonly flag always to true. Therefore, for my specific use-case, the external forward ref to get the content does not cause me a problem. However if you want to consider a generic ability to embed editors it'll need some work (and to expose the remaining envelope API methods).

WDYT?

@kelvah FYI.

packages/embedded-editor/src/editor/Editor.tsx

manstis · 2020-04-28T16:12:06Z

It's plausible this embedded form could be re-used in all the existing channels; rather than repeat the envelope magic, once the necessary API handler functions are passed to Editor as properties from KogitoEditorWrapper.

tiagobento · 2020-04-28T17:25:00Z

Hi @manstis! Please tell me if I'm correct on what I understood from your PR.

The intent of this draft PR is to showcase how an "embedded editor" component would look like.
KogitoEditorWrapper.tsx is a first version of what could be a good candidate for such component.
Editor.tsx is essentially a copy of what's on the other channels.
The webapp on this new embedded-editor package is for demonstration purposes only and would not evolve to be a "deliverable" webapp.

If I actually understood everything correctly, I have some observations, but I'll wait for your response :)

manstis · 2020-04-28T18:08:52Z

@tiagobento Your observations are correct on all accounts.

tiagobento · 2020-04-28T19:06:00Z

@manstis Cool! So here's what I think:

Having an envelope/index.js and an envelope/index.html is necessary. There's no way we can make that reusable if you don't want to depend on external services (which I agree is a good decision). Also, you can potentially have different Routes, if you support different editors.
Pretty much everything that's written on Editor.tsx is channel-specific. Every channel has its own way of registering the communication with the envelope, its own iframe CSS needs, it's own actions to do when receiving a message etc. I agree that it doesn't look like a component atm because you have to use bits of code that are not necessarily related to it, but the abstraction is there. What I think could be a good option is to extract some props, inverting the control, so that the parent of Editor.tsx can decide what to do on each message received, how to register it etc. You don't have to use a context on this component too, since using context was only done on other channels to make the code cleaner.
Having this componentized version of Editor.tsx would allow you to create a ReadonlyEditor.tsx on top of if, since it's a specification of the complete API. WDYT?
I don't understand what "internal" and "external" means on your comments, can you provide more info about that?

manstis · 2020-04-29T12:25:20Z

Hi @tiagobento I've made some changes following the points you mention above.

It might be easier for us to meet and discuss them rather than exchange messages.

manstis · 2020-05-04T14:02:21Z

Hi @tiagobento I've changed the online-editor to use the embedded form.

Perhaps we can meet again to discuss changes and limitations.

packages/online-editor/src/home/HomePage.tsx

packages/online-editor/src/envelope/envelope.ts

packages/online-editor/webpack.config.js

packages/embedded-editor/src/embedded/EmbeddedEditor.tsx

packages/embedded-editor/src/envelope/envelope.ts

manstis · 2020-05-06T15:51:04Z

@tiagobento This PR is now complete (other than tests for embedded-editor).

Both online and desktop re-use the editor and default envelope in embedded-editor.

Did you want to review (with @paulovmr?) before I finish writing tests?

manstis · 2020-05-28T20:58:03Z

packages/embedded-editor/src/envelope/envelope.ts

 });
+


I'd copied and pasted the content of the online-editor envelope when rebasing; so had to restore my change.

manstis · 2020-05-28T21:00:46Z

@tiagobento Updated following successful merge of your keyboard shortcuts PR :-)

ederign · 2020-05-28T21:04:42Z

@jomarko when you have a chance, could you please take a look at this?

jomarko · 2020-05-29T07:51:52Z

Manually checked channels:

chrome extension - from jenkins build
desktop - from jenkins build
online
vs code - from jenkins build

jomarko

@manstis thank you for PR, few general questions

Would be possible to add typedoc to added public API? Especially in new embedded-editor module. Or does it require some pre-cofiguration. Not just /** .... */ in ts files?
In some files github reports missing new line in the end of file. Interested if there is soem pros/cons, recommendations about it.
my yarn run build:prod fails with

@kogito-tooling/online-editor:     src/__tests__/home/HomePage.test.tsx:27:3 - error TS2698: Spread types may only be created from object types.
@kogito-tooling/online-editor:     27   ...jest.requireActual("react-router"),

jomarko · 2020-05-29T07:25:33Z

packages/chrome-extension/package.json

@@ -32,4 +31,4 @@
      "@babel/react"
    ]
  }
-}
+}


I think we shouldn't include changes like this into PRs.

It increases amount of changed lines

Github reports it with red circle. Probably not real issue but makes effect of an error

Added new line. IDK how it went missing but I'll keep an eye on similar in the future.

jomarko · 2020-05-29T07:49:44Z

packages/chrome-extension/src/app/components/common/KogitoEditorIframe.tsx

+    }
+
+    //keep line breaks
+    const content = editorContent.content.split("\n").join("\\n");


Could you please explain need of this escaping? Asking because could be important knowledge for writing tests.

Erm, IDK, to be honest. I just rearranged the existing code to re-use the embedded-editor. It looks to have been added here and possibly the same question was asked at the time.

quality engineers .... :)

@jomarko Hi guys!

tl;dr

We have to append a script tag with the whole XML hard-coded so that we can use the native text editor that GitHub has.

So here's me again with a bit of history and context about our code 😄

To make sure that the "Commit" button works inside GitHub, we have to "integrate" with the existing CodeMirror instance that's running on GitHub's page. That would be very easy if, as extension developers, we had access to the window object of the containing page. Of course that's not the case :)

I think that, for security reasons Chrome, gives the extension code a separate window object, making it not possible for us to access the global CodeMirror classs/function that GtiHub provides. Here's where the workaround begins.

The only way we found to use the CodeMirror instance was by using GitHub's window object, so we dynamically create a script tag and fill it with code that counts on having a CodeMirror object globally available. This script tag is then appended to the original document and magically, we have access to GitHub's window object. To make sure that the code is properly formatted, we have to escape every line break so that we don't simple add a script with line breaks, but create a script tag containing a string that has line breaks in it.

Hope that sheds some light onto it :)

jomarko · 2020-05-29T08:09:36Z

packages/desktop/src/webview/App.tsx

+          dmnPath: "gwt-editors/dmn",
+          bpmnPath: "gwt-editors/bpmn",
+          scesimPath: "gwt-editors/scesim"


This 'App.tsx' has now unused import EditorType I am wondering if it shouldn't be used at this place. Just asking due to other changes in this PR.

Removed import.

An earlier commit in this PR used EditorType values but @tiagobento asked for it to be reverted to the literals.

jomarko · 2020-05-29T08:18:42Z

packages/embedded-editor/jest/jest-env-setup.js

@@ -0,0 +1,20 @@
+/*
+ *  Copyright 2019 Red Hat, Inc. and/or its affiliates.


jomarko · 2020-05-29T08:24:38Z

packages/embedded-editor/src/__tests__/common/File.test.ts

+describe("File::newFile",
+    () => {
+        test("constructor",
+            async () => {
+                const file: File = newFile(EditorType.DMN);
+                expect(file.fileName).toEqual("new-file");
+                expect(file.editorType).toEqual(EditorType.DMN);
+                expect(file.isReadOnly).toBeFalsy();
+
+                await file.getFileContents().then(data => expect(data).toBe(""));
+            });
+    });


Do we have a tests with non empty getFileContents? I had a look on File interface and seems like it is not even possible to set a content of file after creation.

Added a new test with content.

jomarko · 2020-05-29T09:32:07Z

packages/embedded-editor/src/__tests__/embedded/EmbeddedViewer.test.tsx

+  await delay(0); //waits til next event loop iteration
+}
+
+describe("EmbeddedViewer", () => {


Could we please include channel type into description? Or it makes no sense to have same test for different channels. Do we mock in such level that any channel will result into EmbeddedViewer snapshot just with the below?

<body> <div> <iframe/> </div> <body>

I don't have different tests for different channels however I've updated the "defaults" test for both EmbeddedEditor and EmbeddedViewer to assert on more values and revised the test suite description to include ::ONLINE. There are different tests passing different channels in envelope.test.ts.

Corresponding .snap files were regenerated as the "defaults" tests now render the component.

jomarko · 2020-05-29T09:46:17Z

packages/embedded-editor/src/__tests__/envelope/envelope.test.ts

+            return {
+                attributes: {
+                    getNamedItem: (key: string) => {
+                        return { value: key === "data-envelope-channel" ? channelType : undefined };


Just trying to understand stuff. Is 'undefined' just a theoretical option in test? Effect of mocking in combination with the syntax we use? I had a look on real getChannelType() implementation. From there I wouldn't expect 'undefined'. Or I am wrong. The as in getChannelType() can result to undefined?

Your observation is 100% correct. The tests just check that the type of channel is correctly extracted from the DOM by reading the value of the data-envelope-channel attribute on the enclosing IFRAME. This code mocks getNamedItem(..) returning the test channelType or undefined for all other attributes as they're not important for the test.

jomarko · 2020-05-29T09:47:27Z

packages/embedded-editor/src/common/EditorTypes.ts

+export enum EditorType {
+  DMN = "dmn",
+  BPMN = "bpmn",
+  SCESIM = "scesim"


can't we use what we have in embedded editor module?

You've lost me.. this file is in the embedded-editor module (it was moved from online-editor to embedded-editor and changed).

sorry for confusion @manstis

jomarko · 2020-05-29T10:25:06Z

packages/online-editor/src/home/HomePage.tsx

@@ -46,9 +42,13 @@ import {
  ToolbarItem
 } from "@patternfly/react-core";


In one of changed files I saw massive removing of similar imports. So just double checking if here is fine to keep them.

Yes, they appear to still be used by the HomePage screen.

I see here, which is where you may have seen it.. The imports were reformatted onto a single line by the code-formatter we use (possibly as a result of one or two being removed).. the formatter appears to like splitting/combining lines where their length gets too long.

jomarko · 2020-05-29T10:29:12Z

packages/online-editor/src/home/HomePage.tsx

    },
    [context, history]
  );

  const createEmptyBpmnFile = useCallback(() => {
-    createEmptyFile("bpmn");


just double checking. not sure how deep we want to go. If I grep HomePage.tsx there are still also "bpmn" "dmn" string occurrences. For exmaple at place where we say what extension of file is accepted. Is that ok?

I searched HomePage.tsx for both "dmn" and "bpmn" and no occurrences were found.

Can you please advise where you found the occurrences?

manstis · 2020-05-29T11:31:45Z

yarn.lock

@@ -13594,4 +13594,4 @@ zip-webpack-plugin@3.0.0:
  integrity sha512-5kNvPv+TUP3JqKWQUXj0vTgXHIRQpYw5YyBUVXQ0pumTAK+a4OZ+eXDHnh44nyr9B1XJQZq9WtSSm5j6NQhjWQ==
  dependencies:
    webpack-sources "^1.1.0"
-    yazl "^2.4.3"
+    yazl "^2.4.3"


New line added.

manstis · 2020-05-29T12:02:15Z

@jomarko Updates made. Thank-you for your review.

Would be possible to add typedoc to added public API? Especially in new embedded-editor module. Or does it require some pre-cofiguration. Not just /** .... */ in ts files?

Done to embedded-editor

In some files github reports missing new line in the end of file. Interested if there is soem pros/cons, recommendations about it.

Corrected all I could find.

my yarn run build:prod fails...

It works OK here and on the CI environment. Could I suggest it's something local? After fetching my PR did you yarn install it to ensure dependencies were correctly aligned?

jomarko

Thank you @manstis I have nothing more to code, just need to find a way to build and try manually.

jomarko · 2020-05-29T13:08:14Z

I still can not build online-editor module. still same error. I tried even yarn install, yarn upgrade before running yarn run build:prod.

Even running yarn run serve-envelope in chrome-extension-pack... and yarn start in online-editor doesn't help.

tiagobento · 2020-05-29T13:37:16Z

@jomarko yarn run init && yarn run build:prod. Try that :)

tiagobento

Re-approving to ensure that I'm OK to merge it once QE approves and the build is green.

ederign · 2020-06-01T17:29:14Z

@jomarko when you have a chance, could you please take a look at this?

jomarko

Thank you @manstis

manstis · 2020-06-02T11:04:26Z

@ederign I've (obviously!) merged this and updated the "order" of other PRs (as I noticed @tiagobento had been doing). All I need now is a release of the kogito-tooling to npm.... when do you plan on your next release? (There's no hurry for me... and it might be an idea to let this PR settle a bit to ensure there's no regressions). Your call. Thank-you.

ederign · 2020-06-02T12:03:16Z

+1 for that @manstis. Let's this bake a couple of days. I'm also fixing a blocker https://issues.redhat.com/browse/KOGITO-2343 .

The only reason for a release in a hurry would be the vscode release. Probably this will happen next week.

* FDB for PRs: Merge changes from PRs. (#30) * KOGITO-5085: Replace Blob* classes with elemental2 equivalent (#22) * switched to elemental2 Blob implementation * formating * [8.0.0] KOGITO-3274: [DMN Designer] Read-only mode - Connectors appear differently on read-only mode (#31) * BXMSPROD-1311 surefire report check to GA (#144) * BXMSPROD-1311 action-surefire-report * Check Surefire Report errata fixed * BXMSPROD-1311 surefire report check to GA (#116) * BXMSPROD-1311 action-surefire-report * Check Surefire Report errata fixed * KOGITO-5082: Restore the notification mechanism (#23) * Bump version to 8.1.0-SNAPSHOT (#38) * KOGITO-4872: Show an error page for SceSim in case `setContent` fails (#37) * KOGITO-4872: Add ErrorPage for SceSim. * KOGITO-4872: Fix associated test. * Bump version script and workflow (#39) * KOGITO-5068: Online DMN Editor won't load after several tabs are opened (#42) * Bump version to 8.1.1-SNAPSHOT (#43) Co-authored-by: karreiro <karreiro@users.noreply.github.com> * Use token as input in the bump_version workflow (#45) * KOGITO-4977: Stunner - Texts overlap toolboxes (#41) * KOGITO-5021: Clear selection button doesn't work on Testing Tools when use click property first time (#15) * KOGITO-5135: [SceSim Designer] HiDPI is not working as expected (#44) * Kogito-4980 : Stunner - Palette fixes & improvements (#16) * KOGITO-4935 : [DMN/BPMN editor] Sometimes clicking outside doesn't unselect nodes cherry-pick (#47) Co-authored-by: Jaime Enriquez <jenrique@redhat.com> * Add a DMN model into large models test suite (#51) * Workflow for creating the release branch (#46) * KOGITO-5011 - Unknown Custom tasks in Designer makes Diagram Explorer empty (#36) If an item could not be found in the workiItemDefinitionRegistry a null exception was thrown interrupting the load process. * [BXMSPROD-1349] point to ScaCap/action-surefire-report@v1.0.10 (#145) * [BXMSPROD-1349] point to ScaCap/action-surefire-report@v1.0.10 (#118) * Updating Node and Yarn on the FDB workflow (#54) * Update ci_full_downstream_build.yml * Fix FDB workflow * [BXMSPROD-1350] change cache key for flows using different java versions (#119) https://issues.redhat.com/browse/BXMSPROD-1350 * [BXMSPROD-1350] change cache key for flows using different java versions (#146) https://issues.redhat.com/browse/BXMSPROD-1350 * KOGITO-4671 : New elements should always be connected by its central magnetic point (#18) * KOGITO-5003: DMN editor removing edges for duplicate Decision Nodes on canvas (#52) * KOGITO-5132: BPMN Editor - Improve SVG generated ids (#3634) (#48) * upgraded to next 7.56.0-SNAPSHOT * upgraded to next 7.56.0-SNAPSHOT * Revert "upgraded to next 7.56.0-SNAPSHOT" This reverts commit 7da188f. * Revert "upgraded to next 7.56.0-SNAPSHOT" This reverts commit f475cf3. * upgrade to next SNAPSHOT version * upgrade to next SNAPSHOT version * Lienzo migration to J2CL * Lienzo migration to J2CL * Lienzo migration to J2CL * Lienzo migration to J2CL * KIE codestyle conventions applied * KIE codestyle conventions applied * KIE codestyle conventions applied * Lienzo Core migration to J2CL & kogito editors. * Lienzo Tests migration to J2CL & kogito editors. * Lienzo Webapp migration to J2CL & kogito editors. * Dependency updates for kogito lienzo artifacts. * fix SCESIM tests * Fix lienzo-tests - unit tests not running * BXMSPROD-1353 nodejs v16.2.0 (#62) * BXMSPROD-1353 nodejs v16.2.0 * Update appformer-js-monaco/pom.xml Co-authored-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> Co-authored-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Lienzo codebsae clean ups * KOGITO-5142: [DMN/BPMN] Sync kogito-editors-java with latest translations (#50) * Updated Test Scenario translations (#49) * Set missing generateJsInteropExports flag for GWT apps * Lienzo - Fix shape exclusions in layer index * KOGITO-4043: The nodes should be created on top of the selected node in DMN editor (#58) * Lienzo webapp - Cleanup & fixes for examples * Lienzo - Drop unused Metadata type * Lienzo - Drop unused RestrictedMousePanMediator type * Lienzo - Code Cleanup * Bump version to 8.2.1-SNAPSHOT (#67) * KOGITO-5225/KOGITO-5154: Support React components on Kogito Java-editors (#68) * Fixed canvas not being automatically resized on readOnly mode * DMN - Fixed decision service divider not working properly on drag * Lienzo - Upgrade modules to version 8.2.1-SNAPSHOT * KOGITO-4899: SceSim - Redraw layer after user action. * KOGITO-4941: [DMN Editor] Ctrl-B always converts field to structure and nests (#69) * Lienzo - Drop legacy json serialization & validation stuff. * Lienzo - Clean up gwt compilation warns for jsinterop types. * BXMSPROD-1340 kogito-tooling nightly * KOGITO-5137: Conscious language initiative (#72) * KOGITO-5489: [DMN Designer] When users create a node by using a shortcut, it's not created above (#74) * KOGITO-4978 : Make new nodes Editable (#26) * KOGITO-5470 : BPMN Editor - Cannot import process (#71) * Lienzo & Stunner migration to native - Code cleanups * KOGITO-5549 - WID files with comments and Imports can't be loaded (#76) * KOGITO-1625: [DMN Designer] Data Types changes do not mark asset as dirty (#73) * KOGITO-5571: No effects when assigning a not-expression Simple Type column to expression type (and viceversa) (#79) * KOGITO-5119: [DMN Designer] Add support for bend-points on connectors (#78) * KOGITO-5506 : BPMN Editor - Marshallers encoding issues (#75) * KOGITO-5506 : BPMN Editor - Marshallers encoding issues * KOGITO-5506 : BPMN Editor - Marshallers encoding issues * KOGITO-5091: Stunner - creating connection can't be cancelled easily (#80) * KOGITO-5557 [DMN Designer]: Boxed Expression - Move the new boxed expression to Kogito stream (#77) * KOGITO-2313 - Support for node/events metadata attributes (#64) * KOGITO-4765: Errors when executing models using imported inputs and/or decisions nodes - VS Code (#17) * KOGITO-5481: JS - Solve performance gap (large boxed expressions takes too long to load - Relation 50x50) demo | branch - CSS / JS/TS/Hooks (#82) * KOGITO-5119: Add DMN diagram bend points marshalling test (#81) * KOGITO-4979 - Resize control points - Fixes & UX improvements (#84) * KOGITO-5481: Add 50x50 Relation cypress test (#88) * KOGITO-5469 : Can't connect elements vertically far from each other in a BPMN Diagram (#87) * KOGITO-5274: Stunner - Line splicing (#85) * KOGITO-5594: [Stunner] bend point modification causes diagram inaccessible (#92) * KOGITO-3654: Support FEEL code completion and code highlighting on all FEEL based cells (#83) * KOGITO-5646: [DMN Designer] New boxed expression editor - Create a mechanism to enable the new boxed expression editor as a toggle feature (#89) * KOGITO-5648: [DMN/BPMN] Wired web apps - Fix doc screenshot (#91) * KOGITO-5642: Fix sonnar issues: try-with-resources * KOGITO-5642: Fix sonar issues: deprecated JsonFactory method * KOGITO-5642: Fix sonar issues: Unused public methods * KOGITO-5642: Fix sonar issues: disable external entities access * KOGITO-5642: Fix sonar issues: remove not used class field * KOGITO-5642: Fix sonar issues: remove unused import * Remove unclosed opening quotes * Remove not needed eq matcher * Create CODEOWNERS * Add CODEOWNERS * Bump version to 8.3.1-SNAPSHOT (#96) Co-authored-by: Kogito Tooling Bot <kietooling@gmail.com> * KOGITO-5613: Add pre-push hooks to run prettier and eslint in kogito-editors-js (#86) * KOGITO-5728: [DMN Designer] New Boxed Expression editor - Remove "|" grip from the new boxed expression editor (#98) * kie-parent version bump for 7.58.0.Final (#93) * DROOLS-6477: Collections Data Objects can be filled with expressions only. (#97) * KOGITO-3909: Standalone DMN editor missing isDirty indication on datatype or included models change (#99) * KOGITO-5149: Create the second step of the Wizard - Create the collapsible/expandable list of future Data Types (#101) * KOGITO-5676: BPMN Editor - Containment not working when Node overlaps the Connector while splicing (#95) * KOGITO-5642: Activate sonar check (#94) * KOGITO-5642: Activate sonar check * Add jenkinsfile to run analysis on PR * Stabilize test on run-code-coverage profile * Create pipeline * Remove sonarcloud-analysis profile config * Skip gwt compilation for run-code-coverage profile * Convention over configuration - default repository * Decrease from 16G nodes to 8G nodes * skop sonar for dmn-webapp-[kogito-runtime|kogito-testing] * KOGITO-5642 Fix CI job ID (#107) Folders in jenkins workspace are generated according to the job ID. Whitespaces in the ID causes an issues. * KOGITO-5642: Do not run github action for some paths (#108) * Fix indentation in on:push sonar github action (#111) For more details see: - https://github.com/kiegroup/kogito-editors-java/actions/runs/1234074225 * Fix FDB build (#110) * Bump version to 8.4.1-SNAPSHOT (#112) * Fix FDB build * KOGITO-3661 Integrate boxed-expression-component inside dmn-loader and define jsInterop classes for loading/saving expressions (#104) KOGITO-3661 Integrate boxed-expression-component inside dmn-loader and define jsInterop classes for loading/saving expressions (#104) * KOGITO-3656: Support copy/paste integration with other spreadsheets (#103) KOGITO-3656: [DMN Designer] New boxed expression editor - Support copy/paste integration with other spreadsheets KOGITO-5649: [DMN Designer] New boxed expression editor - Support single/multiple cells highlight * KOGITO-5909: [DMN Designer] New Boxed Expression editor - DMN Expression column width is updated too many times in some scenarios (#116) * Update ci_full_downstream_build.yml * KOGITO-5901: [DMN/BPMN/SceSim] Check dependabot alerts (#115) * KOGITO-5933: Enable the new Boxed Expression Editor in all Kogito channels (#118) * Update codeowners file (#121) * scesim translations update (#123) * KOGITO-5894: Fix spotbugs issues (#106) * Bump version to 8.4.2-SNAPSHOT (#124) * KOGITO-5847: Fix critical issues reported by sonar (#113) * DROOLS-4719: Change decision navigator DRG icon (#126) For more details see: - https://issues.redhat.com/browse/DROOLS-4719 * KOGITO-6033: Make DMN data types documentation entries readable (#125) For more details see: - https://issues.redhat.com/browse/KOGITO-6033 * KOGITO-6021: [DMN Designer] Multiple DRDs - Renaming a DRD freezes the browser (#127) * KOGITO-6021: Value is updated only if changed * KOGITO-6021: Value is updated only if changed * KOGITO-6021: Value is updated only if changed * KOGITO-6021: Applying Change Requests * KOGITO-5849: use existing sonarcloud-analysis profile (#130) * KOGITO-5849: use existing sonarcloud-analysis profile * Actiavte sonar check for lienzo-webapp * Peer review feedback: clarify sonarcloud-analysis definition location * Revert "KOGITO-5909: [DMN Designer] New Boxed Expression editor - DMN Expression column width is updated too many times in some scenarios (#116)" (#132) This reverts commit ab89715. The reason of revert is described in comments: - #631 (comment) - #631 (comment) * KOGITO-6021: test DRD rename is propagated (#131) For more details see: - https://issues.redhat.com/browse/KOGITO-6021 * Optimizing bundle by removing comments that were causing issue with kogito-tooling standalone editors (#137) * KOGITO-5150: Create the mechanism for fetching fields from nest types (#122) * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Changes requests * KOGITO-5150: Snapshots tests fixed * KOGITO-5150: Wizard cleanup at closure * KOGITO-5150: Wizard cleanup at closure * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Changes requests * KOGITO-5150: Snapshots tests fixed * KOGITO-5150: Wizard cleanup at closure * KOGITO-5150: Wizard cleanup at closure * KOGITO-5150: Applying Change Requests * KOGITO-5150: Applying Change Requests * KOGITO-5150: Applying Change Requests * KOGITO-5150: Prettier is now happy * KOGITO-5150: Prettier is now happy * KOGITO-5150: Snapshots updated * KOGITO-5150: Tests * KOGITO-5150: Tests * KOGITO-5150: Tests * KOGITO-5150: Tests * KOGITO-5150: Prettier * KOGITO-6037: Render DMN Shapes colors (#140) For more details see: - https://issues.redhat.com/browse/KOGITO-6037 * Bump version to 8.4.3-SNAPSHOT (#138) * Use try-with-resources for JavassistAdapter (#139) * KOGITO-6083: Render new lines in DMN documentation node description (#136) * KOGITO-6083: Render new lines in DMN documentation node description For more details see: - https://issues.redhat.com/browse/KOGITO-6083 * Trigger build * Fix batch of lienzo-core issues reported by sonar (#142) * KOGITO-5973: Stunner - Provide an initial JS/TS API to interact with nodes and connectors (#117) * DROOLS-3300: merge background and font set (#134) For more details see: - https://issues.redhat.com/browse/DROOLS-3330 * KOGITO-5152: Data Types - Wizard - Create the third step of the Wizard (#133) * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Changes requests * KOGITO-5150: Snapshots tests fixed * KOGITO-5150: Wizard cleanup at closure * KOGITO-5150: Wizard cleanup at closure * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Fetching mechanism * KOGITO-5150: Changes requests * KOGITO-5150: Snapshots tests fixed * KOGITO-5150: Wizard cleanup at closure * KOGITO-5150: Wizard cleanup at closure * KOGITO-5150: Applying Change Requests * KOGITO-5150: Applying Change Requests * KOGITO-5150: Applying Change Requests * KOGITO-5150: Prettier is now happy * KOGITO-5150: Prettier is now happy * KOGITO-5150: Snapshots updated * KOGITO-5150: Tests * KOGITO-5150: Tests * KOGITO-5150: Tests * KOGITO-5150: Tests * KOGITO-5150: Prettier * KOGITO-5152: Third Step * KOGITO-5152: Third Step * KOGITO-5152: Third Step * KOGITO-5152: Tests * KOGITO-5152: Tests * KOGITO-5152: Tests * Fix dev environment BPMN/DMN kogito-runtime, xml-apis dependency (#148) * DROOLS-3442: Rename DMN 'Name' to 'DMN Model Name' (#135) For more details see: - https://issues.redhat.com/browse/DROOLS-3442 * KOGITO-5899: When editing a BKM node, clear button should not be available for the boxed Function (#141) * LogicTypeSelector receives an external property to decide when showing or not the clear button * The dmn-loader passes a property to the editor for showing or not the clear button on the root expression * Based on clear support method, of HasExpression interface, passing a boolean to the dmn-loader * Reusing the `noClearAction` property of the `ExpressionProps` interface, in order to make clear action not available on root expression * Adding documentation to render method * Adding documentation to BoxedExpressionEditor * Bump version to 8.5.1-SNAPSHOT (#149) * Removing css conflict file and hiding button for switching to new editor (#150) * RHDM-1611: Show vertical scrollbar on small screen for data types placeholder (#153) * KOGITO-6188: [DMN Designer] The keyboard shortcuts modal CSS from the DMN Editor is broken (#155) * Creating a separate CSS file with rules from `base-no-reset.css` that have been wrapped to avoid potentially dangerous side effects * Fixing showcase in order to use `base-no-reset-wrapped.css` for the remaining part of the editor * Re-enabling `boxed-expression-component` inside `DMN Editor` * Bump version to 8.5.2-SNAPSHOT (#157) * Enable Included Models on Online Multi-file channel (#156) * Avoid the activation of Boxed Expression Editor during Diagram -> Editor navigation (#163) * KOGITO-6132: [DMN Designer] Pressing backspace when editing a node deletes the node (#146) * KOGITO-6132: [DMN Designer] Pressing backspace when editing a node deletes the node * Rebuild * KOGITO-6222: [DMN Designer] Open Imported DMN from current model (#161) * KOGITO-6222: Open a DMN included file reference in another tab * KOGITO-6222: Test * KOGITO-6222: Tests * KOGITO-6222: Tests * KOGITO-6222: Tests * Api refactoring * Update kie-wb-common-dmn/kie-wb-common-dmn-client/src/main/java/org/kie/workbench/common/dmn/client/editors/included/grid/BaseCardComponent.java Co-authored-by: Jozef Marko <jomarko@redhat.com> * KOGITO-6222: Tests Co-authored-by: Jozef Marko <jomarko@redhat.com> * KOGITO-6036: Use html <input type='color'> picker (#147) * KOGITO-6036: Show colors as hex value string in forms For more details see: - https://issues.redhat.com/browse/KOGITO-6036 * Fix codesmell: non standard package name * Use html5 <input type='color'/> * Cleanup dependencies * sonar: remove unused field * KOGITO-5078: DMN Runner Tabular Input (#145) * Adding modifications * Working * Working * Fix FunctionExpression * Fix RelationExpression * Fix RelationExpression resize * Fixing FunctionExpression resize * WIP Fix FunctionExpression resize * Fix resize * Fix FunctionExpression and RelationExpression * Update api * Add dmn-runner-showcase * Update tests * Update i18n version * Update react-table types * Make it possible to resize the dmn runner table * Fix dmn-runner-showcase start * Add source maps * Fix test * Minor tweaks * Fix dmn runner table resize * Fix FunctionParameters and DmnAutoTable render * Lint * Fix Tests * Fix EditableCell tests * Fix nested ListExpression * Move reset LogicType test to BoxedExpressionEditor * Fix DmnRunnerTabular resize * Fix incompatible type * Remove dmn runner showcase * Clean changes * Add github action * Fix workflow * Fix comment * Remove unused script * Fix i18n version * Fix lint * Retrigger build * Fix InvocationExpression * Update on function name change * Refactor FunctionExpression * Remove warnings * Remove unnecessary states * Remove unnecessary states * Remove unnecessary states * Fix ResizableCell render delay * Fix tests * Fix FunctionExpression test * re-trigger build * Remove CellSelectionBox from DMN Runner Table * Remove duplicated import * Add css to showcase * Stop using the document.body to search for cells * Remove unused imports * Fix github action, update version of all packages * Fix tests * Fix EditParameters * Fix onFocus * Refactor DecisionTable * Fix FeelInput * Check if state has changed before update * Simplify content update on Java and PMML functions * Fix tests * Fix PMML parameters * Revert changes on feelinput * Fix css * Fix FeelInput component * Fix clean result * Fix format * Fix Relation column rename * Remove unnecessary css * Remove unused imports * Re trigger build * Fix DecisionExpression Cell handler * Bump version to 8.5.4-SNAPSHOT (#165) * Bump version to 8.5.3-SNAPSHOT * Bump version to 8.5.4-SNAPSHOT * KOGITO-5848: Activate sonar for kogito-editors-js module (#160) For more details see: - https://issues.redhat.com/browse/KOGITO-5848 * Remove duplicit gwt-maven-plugin definition (#164) This a fix for the warning from build: Some problems were encountered while building the effective model for org.kie.kogito:lienzo-webapp:war:8.5.2-SNAPSHOT Warning: 'profiles.profile[GWT2].plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.codehaus.mojo:gwt-maven-plugin @ line 239, column 14 Warning: Warning: It is highly recommended to fix these problems because they threaten the stability of your build. Warning: Warning: For this reason, future Maven versions might no longer support building such malformed projects. Warning: * Use lerna to change packages version (#168) * RHPAM-3329: Increase Decision Table Output value length limit (#152) * Measure kogito-editors-js coverage (#167) * Measure kogito-editors-js coverage * fix ci * Fix `locktt` install (#172) * Create pom.xml * Update pom.xml * Update pom.xml * Upgrade frontend-maven-plugin to enable the 'npx' goal * Fix locktt on appformer-js-monaco too * KOGITO-6097: [New DMN Expression Editor] decision table can not be opened (#159) * Adding exported function for generating UUID * First column of Relation table should have 100 px of width * Accessor for added columns is the generated uuid * Using identifier for accessing the columns * Identify each table row by its ID * Identify columns and rows in Relation table, by their ID * Fixing tests after introduction of ID * Id for Relation table should not be generated when evaluating rows, otherwise it will be different at every render * Generating IDs for DecisionTable's columns * When adding a new row, a generated uuid should be used for it * When rendering the table, if a row is missing the id, going to generate it * Giving minimum height to label section, in order to have space when label is empty * Edit of inline text (annotation labels) should accept empty values * Changing props Java classes to reflect Id param * Overriding PF label color (that on DMN Editor is white) * Filling id of Annotation and Clause DecisionTable's props * Id for inputClause should not be taken from its wrapped inputExpression * Fixing test case * Retrieve ruleId from the model * Fixing cypress test case * Rows in Relation table must have a dedicated ID * Updating cypress relation test * Changing Props java class to save rows identifiers in Relation tables * Display JSON definition with collapsable sections * Table's rows identifier * Generating uuid for rows * Table's column id * Solving conflicts in DecisionTableExpression * Solving conflicts in RelationExpression * Solving issue introduced after KOGITO-5078: when selecting Literal as Expression type, the expression definition should be updated accordingly * Bump version to 8.5.4-SNAPSHOT (#165) * Bump version to 8.5.3-SNAPSHOT * Bump version to 8.5.4-SNAPSHOT * KOGITO-5848: Activate sonar for kogito-editors-js module (#160) For more details see: - https://issues.redhat.com/browse/KOGITO-5848 * Remove duplicit gwt-maven-plugin definition (#164) This a fix for the warning from build: Some problems were encountered while building the effective model for org.kie.kogito:lienzo-webapp:war:8.5.2-SNAPSHOT Warning: 'profiles.profile[GWT2].plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.codehaus.mojo:gwt-maven-plugin @ line 239, column 14 Warning: Warning: It is highly recommended to fix these problems because they threaten the stability of your build. Warning: Warning: For this reason, future Maven versions might no longer support building such malformed projects. Warning: * Use lerna to change packages version (#168) * RHPAM-3329: Increase Decision Table Output value length limit (#152) * Measure kogito-editors-js coverage (#167) * Measure kogito-editors-js coverage * fix ci * Extend relation and decision table coverage * Empty dependencies array for `useEffect` - executing spread of literal expression definition only the first time the component is rendered * Removing `useEffect` from `LiteralExpression` * Using _.chain method instead of directly _.map/_.reduce Co-authored-by: Yeser Amer <yamer@redhat.com> Co-authored-by: Jozef Marko <jomarko@redhat.com> Co-authored-by: Luiz João Motta <luizjoaomotta@gmail.com> * KOGITO-6144: DMN Editor missing xml-prolog for UTF-8 encoding (#154) * KOGITO-6144: add xml declaration prolog For more details see: - https://issues.redhat.com/browse/KOGITO-6144 * Fix sonar issues * Start kogito-editors-js cypress tests as part of CI build (#173) * KOGITO-6262: Extend new boxed expression editor decision table coverage (#170) For more details see: - https://issues.redhat.com/browse/KOGITO-6262 * KOGITO-6262: Regressions on DecisionTable, after KOGITO-5078 (#171) * Fix new column prefix * Fix ContextExpression reset cell * Fix DecisionTableExpression name on nested expression * Sync ContextEntryInfo and DecisionTable name and dataType * Remove unnecessary states * KOGITO-6045: The canvas now expands automatically anytime a primitive is dragged beyond control limits. (#129) * DROOLS-5197,5744 - DMN Enumeration constraint editor small enhancements (#169) As part of this PR we: - prevent user from defining same enumeration item multiple times: https://issues.redhat.com/browse/DROOLS-5197 - commit all enumeration items in edit mode by click on single checkbox: https://issues.redhat.com/browse/DROOLS-5744 * Enable tests for KOGITO-6262 (#177) * KOGITO-6326: Regressions on LiteralExpression, after KOGITO-5078 (#180) * Fix LiteralExpression first render * KOGITO-6326: Test a literal expression data type change * Formater Co-authored-by: Jozef Marko <jomarko@redhat.com> * BXMSPROD-1558 install lock-treatment-tool exec (#184) * BXMSPROD-1558 install lock-treatment-tool exec * BXMSPROD-1558 lock-treatment-tool replaced by @kie/lock-treatment-tool * BXMSPROD-1558 lock-treatment-tool replaced by @kie/lock-treatment-tool * BXMSPROD-1558 @kie/lock-treatment-tool@^0.0.2 * trying with -- * trying double * one single execution with -- * one single execution with -- * one single execution with -- * one single execution with -- * one single execution with -- * Update .ci conf to get sonar report (#187) Previously there was a check of a SONARCLOUD_ENABLED variable to be sure we should run sonar checks. However this check was broken by recent change: - kiegroup/kogito-pipelines@2724907#diff-a6b82d55b9b456d5762e2acda0ee91fb6ac26087c8eb1db4697ed1d911959671 This we decided to simplify kogito-editors-java Jenkinsfile to get sonar CI checks working again Update .ci/jenkins/dsl/jobs.groovy Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Revert missing import in .ci conf (#188) * Revert missing import in .ci conf * Add github action to validate jenkins job definitions files * KOGITO-3662: Boxed Expression Editor should use UIDv4 for handling identifiers of elements (#182) * Adding exported function for generating UUID * First column of Relation table should have 100 px of width * Accessor for added columns is the generated uuid * Using identifier for accessing the columns * Identify each table row by its ID * Identify columns and rows in Relation table, by their ID * Fixing tests after introduction of ID * Id for Relation table should not be generated when evaluating rows, otherwise it will be different at every render * Generating IDs for DecisionTable's columns * When adding a new row, a generated uuid should be used for it * When rendering the table, if a row is missing the id, going to generate it * Giving minimum height to label section, in order to have space when label is empty * Edit of inline text (annotation labels) should accept empty values * Changing props Java classes to reflect Id param * Overriding PF label color (that on DMN Editor is white) * Filling id of Annotation and Clause DecisionTable's props * Id for inputClause should not be taken from its wrapped inputExpression * Fixing test case * Retrieve ruleId from the model * Fixing cypress test case * Rows in Relation table must have a dedicated ID * Updating cypress relation test * Changing Props java class to save rows identifiers in Relation tables * Display JSON definition with collapsable sections * Table's rows identifier * Generating uuid for rows * Table's column id * Solving conflicts in DecisionTableExpression * Solving conflicts in RelationExpression * Solving issue introduced after KOGITO-5078: when selecting Literal as Expression type, the expression definition should be updated accordingly * Bump version to 8.5.4-SNAPSHOT (#165) * Bump version to 8.5.3-SNAPSHOT * Bump version to 8.5.4-SNAPSHOT * KOGITO-5848: Activate sonar for kogito-editors-js module (#160) For more details see: - https://issues.redhat.com/browse/KOGITO-5848 * Remove duplicit gwt-maven-plugin definition (#164) This a fix for the warning from build: Some problems were encountered while building the effective model for org.kie.kogito:lienzo-webapp:war:8.5.2-SNAPSHOT Warning: 'profiles.profile[GWT2].plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.codehaus.mojo:gwt-maven-plugin @ line 239, column 14 Warning: Warning: It is highly recommended to fix these problems because they threaten the stability of your build. Warning: Warning: For this reason, future Maven versions might no longer support building such malformed projects. Warning: * Use lerna to change packages version (#168) * RHPAM-3329: Increase Decision Table Output value length limit (#152) * Measure kogito-editors-js coverage (#167) * Measure kogito-editors-js coverage * fix ci * Extend relation and decision table coverage * Empty dependencies array for `useEffect` - executing spread of literal expression definition only the first time the component is rendered * Removing `useEffect` from `LiteralExpression` * Using _.chain method instead of directly _.map/_.reduce * Removing `react-id-generator` from peerDependencies list * Renaming `uid` to `id` property * Using `generateUuid` instead of `nextId` as id * Each expression type has an `id` property * LiteralExpression body cell id is the one related to the LiteralExpression * Context row id is equal to the entryInfo id (variable) * Table columns should contain column id in the <Th> class * Wrapped LiteralExpression of Java, PMML Function must have their own ids * PMMLLiteralExpression has his own identifier * Spreading field ids for Java and PMML function expressions * Specific LiteralExpression class based on function kind * Invocation biding ids population * Passing list expression id to props and viceversa * Passing expression ids from model to props and viceversa * BoxedExpressionEditor accepts the decisionNodeId parameter * Putting decisionNodeId in the Context API * The decisionNodeId is used as identifier for the output column at highest level * Fixing ListExpression.test * Passing decision node id to DMNLoader * Fixing existing tests after PMML function improvement * Decision node id should be set only for root expressions * Using Nullish coalescing operator for string check * Populating Parameter class like in LiteralExpressionPMMLDocumentModelEditorDefinition.java * Renaming cssClasses * Using constants for identifying the first and second entries Co-authored-by: Yeser Amer <yamer@redhat.com> Co-authored-by: Jozef Marko <jomarko@redhat.com> Co-authored-by: Luiz João Motta <luizjoaomotta@gmail.com> * KOGITO-6407: fix outdated browserlist warning (#193) For more details see: * https://issues.redhat.com/browse/KOGITO-6407 * Remove duplicated .gitignore entry - coverage (#190) * KOGITO-5901: Resolving dependabot alerts (#191) * KOGITO-5901: Removing unused netty dependency * KOGITO-5901: Removing unused netty dependency * KOGITO-6289: Regressions on copy/paste from other spreadsheet, after KOGITO-5078 (#181) * Fix SelectionBox visualization * Fix paste new values on RelationExpression * Change listeners to boxed-expression-editor instead of document * Omit isHeadless property * Use document as fallback container * Update tests snapshots * Remove unused import * Refactor onRowsUpdate to use object as arg instead of multiple optional ones * Refactor to use the Boxed Expression ref instead of id * Use boxed expression container instead of document on paste * Use boxed expression container instead of document on resizer * Update snapshots * Update onRowsUpdate to use object * Remove usage of document as fallback * Update tests to use the editorRef and add missing containers * Fix tests * Fix import * Change DecisionExpression spread parameter to object * Change onColumnsUpdate to use args * Linter * Revert tsconfig * Rename container to editorElement * Update snapshots * Make boxed expression to have the parent heigth * Update test snapshot * Automate copy and paste test * Fix DMN boxed editor height * Extract relation expression definition to separate logic * Change Boxed Editor height on showcase * Fix pom.xml command Co-authored-by: Jozef Marko <jomarko@redhat.com> * KOGITO-4195: [DMN Designer] New boxed expression editor - Support undo/redo in Boxed Expression Editor (#175) * KOGITO-4195: [DMN Designer] New boxed expression editor - Support undo/redo in Boxed Expression Editor * rebuild * Fix tests * rebuild * Code Review #1 * Prettier * rebuild * Prettier * Some refactor and test coverage * Code review #2 * Move to new folder * Building online-editor fine * Format code * Updates * Remove unecessary build args in Maven packages * Update versions to 0.0.0 and update versions script * build:prod working without tests * Renaming references to kogito-tooling instead of kogito-editors-java * Consolidate .gitignores * Add --env live option to DMN Loader * Monorepo general enhancements * Renaming env var * Fix Jest tests * Update more snapshots * Remove maven cache on CI * Fix PF loaders on windows * Change Maven setup * Fix Maven setup on CI * Fixing READMEs and Maven config on CI * Scripts cleanup and fix build on Windows * Oops. Update yarn.lock * Fix build on Windows * Fix symlinks on Windows and Sonar workflow * Fix maven default args on setup-env * Fix kogito-editors-java package.json * Update graph.dot * Increase JVM memory * Include dependencies on NPM Packages release job * Fix JVM memory increase * Pagefile on Windows * Oops * Setup kogito-tooling-bot before merging * Fix showcases * Oops. Update yarn.lock * Oops. Dependency version mismatches * Fix Standalone Editors tests and add test:it to build:prod on boxed-expression-component * Fix dependency mismatches * Oops. yarn.lock * Paralel maven builds * Remove paralel maven builds * Skip IT tests for stunner-editors and testing webapps compilation * Skip IT tests for stunner-editors build:prod * Disable IT tests on boxed expression and remove dmn-runner-showcase from unitables * Update graph.dot * Enable boxed-expression-component tests * Unskip Resizer tests on boxed-expression-component * Update Jenkinsfile sonar checks paths (#41) This changes are related to monorepo migration #729 * Skipping Decision Table Expression tests * Skip DMN VS Code test * Unskip test and increase timeout to open webview on VS Code * Change editor name from SceSim to Test Scenario Co-authored-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> Co-authored-by: Dmitrii Tikhomirov <treblereel@users.noreply.github.com> Co-authored-by: Daniel J dos Santos <danielzhe@users.noreply.github.com> Co-authored-by: Enrique Mingorance Cano <emingora@redhat.com> Co-authored-by: Guilherme Carreiro <karreiro@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: karreiro <karreiro@users.noreply.github.com> Co-authored-by: Kirill Gaevskii <hasysin@gmail.com> Co-authored-by: Yeser Amer <yamer@redhat.com> Co-authored-by: Jaime Enriquez <jaime.enriquez@inodesoft.com> Co-authored-by: Jaime Enriquez <jenrique@redhat.com> Co-authored-by: Jozef Marko <jomarko@redhat.com> Co-authored-by: Wagner Scholl Lemos <josephblt@gmail.com> Co-authored-by: Roger Martínez <roger600@gmail.com> Co-authored-by: Michael Biarnes Kiefer <mbiarnes@redhat.com> Co-authored-by: Handrey Cunha <handrey.cunha@gmail.com> Co-authored-by: Alberto Morales <almorale@redhat.com> Co-authored-by: Marek Novotný <hotmana76@gmail.com> Co-authored-by: Kirill Gaevskii <kgaevski@redhat.com> Co-authored-by: Valentino Pellegrino <vpellegr@redhat.com> Co-authored-by: Handreyrc <47090342+handreyrc@users.noreply.github.com> Co-authored-by: Kogito Tooling Bot <kietooling@gmail.com> Co-authored-by: Eder Ignatowicz <ignatowicz@gmail.com> Co-authored-by: Luiz João Motta <luizjoaomotta@gmail.com> Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com>

manstis assigned ederign and tiagobento Apr 28, 2020

manstis commented Apr 28, 2020

View reviewed changes

packages/embedded-editor/src/editor/Editor.tsx Outdated Show resolved Hide resolved

manstis commented Apr 28, 2020

View reviewed changes

packages/embedded-editor/src/editor/Editor.tsx Outdated Show resolved Hide resolved

manstis force-pushed the FAI-105 branch from 2f37dc8 to 93408d8 Compare April 29, 2020 12:24

manstis requested review from tiagobento and ederign April 29, 2020 12:25

manstis unassigned ederign and tiagobento Apr 29, 2020

manstis commented May 4, 2020

View reviewed changes

packages/online-editor/src/home/HomePage.tsx Outdated Show resolved Hide resolved

manstis commented May 4, 2020

View reviewed changes

packages/online-editor/src/envelope/envelope.ts Outdated Show resolved Hide resolved

manstis changed the title ~~FAI-105: Clone online- to embedded- before refactor~~ FAI-105: Embed kogito-tooling editors in trusty-ai May 4, 2020

manstis commented May 4, 2020

View reviewed changes

packages/online-editor/webpack.config.js Show resolved Hide resolved

manstis force-pushed the FAI-105 branch from 8b371e6 to be215c5 Compare May 4, 2020 15:38