[LIVY-566] When cancel a sql job through livy, actually the sparkjob still running #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagar
reviewed
Mar 11, 2019
| @@ -59,7 +59,7 @@ public SqlJob( | |||
|
|
|||
| @Override | |||
| public Void call(JobContext ctx) throws Exception { | |||
| ctx.sc().setJobGroup(statementId, statement); | |||
| ctx.sc().setJobGroup(statementId, statement) | |||
There was a problem hiding this comment.
Is setting job description as statement text related to LIVY-566?
If yes, job description might need to be set to something else? as statement text can contain sensitive information.
Thanks.
There was a problem hiding this comment.
The particular change you're commenting on is not part of this PR. In fact this PR does not compile, because this change is wrong...
vanzin
reviewed
Mar 11, 2019
| @@ -60,6 +58,8 @@ class LivyExecuteStatementOperation( | |||
|
|
|||
| private def statementId: String = opHandle.getHandleIdentifier.toString | |||
|
|
|||
| private var jobHandle: JobHandle[_]=_ | |||
There was a problem hiding this comment.
add spaces around =. Also later.
But really I think the correct fix would be in ThriftSessionState.cleanupStatement. Seems I missed to port some code from the old implementation when creating that class: 39fa887#diff-712ea78474e0573e4dbe90b46f67ff05L160
|
Closing due to no reply. I'll post my own fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/LIVY-566
(Please fill in changes proposed in this fix)
(Include a link to the associated JIRA and make sure to add a link to this pr on the JIRA as well)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review https://livy.incubator.apache.org/community/ before opening a pull request.