Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Pre-release modifications #59

Merged
merged 11 commits into from
Jan 19, 2022
Merged

Pre-release modifications #59

merged 11 commits into from
Jan 19, 2022

Conversation

cardosolucas
Copy link
Contributor

Some modifications to create engine-executor docker image and package name changing.

Copy link
Member

@Wei-1 Wei-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something weird going on with the virtualenv version on travis-ci that is causing this.
The only difference that I can find is that virtualenv got updated from 20.8.1 to 20.9.0 or 20.10.0 and things stop working.
Let's test around to see if we can solve this.

@Wei-1
Copy link
Member

Wei-1 commented Nov 27, 2021

I tested with a minimum tweak, but it doesn't work in #60
I had also print more logs from tox in that PR, you can check if there is anything helpful, although it doesn't seem useful to me.

@cardosolucas
Copy link
Contributor Author

It seems like the problem is with the installation of cryptography library. The openssl required version is > 1.1.0 but we have > 1.0.0. I have tried some fixes but it doesn't work. I'll continue to work on it tomorrow.

.travis.yml Outdated
@@ -37,7 +37,7 @@ matrix:
- language: python
os: linux
python:
- 3.6
- "3.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, the build configuration had not been changed: https://github.com/apache/incubator-marvin/runs/4835434559

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was getting stuck on validation.

@cardosolucas
Copy link
Contributor Author

It's working now. I changed the ubuntu version to get the right openssl version installed.

@Wei-1
Copy link
Member

Wei-1 commented Jan 18, 2022

I will check and merge it before weekend!

@asfgit asfgit merged commit bc6768e into apache:develop Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants