-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add up_textheap_heapmember #6306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Although bytecodealliance/wasm-micro-runtime#1181 calls directly into arch code. We briefly discussed this before, and some ideas where mallopt
and maybe also PROT_EXEC
for mmap
.
where was it discussed? i agree something more generic is nicer. i considered to fix mmap. but it involves unnecessary overhead for this particular application. |
Just internally, given the different regions ESP32 has. |
Based on nuttx patch "Add up_textheap_heapmember": apache/nuttx#6306
Based on nuttx patch "Add up_textheap_heapmember": apache/nuttx#6306
Based on nuttx patch "Add up_textheap_heapmember": apache/nuttx#6306
Summary
intended usage: bytecodealliance/wasm-micro-runtime#1181
Impact
Testing
a wamr aot module tested on esp32. (with various other patches)
cxd56xx and esp32c3 are not tested.