Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add up_textheap_heapmember #6306

Merged
merged 5 commits into from
May 20, 2022
Merged

Add up_textheap_heapmember #6306

merged 5 commits into from
May 20, 2022

Conversation

yamt
Copy link
Contributor

@yamt yamt commented May 20, 2022 •
edited
Loading

Summary

intended usage: bytecodealliance/wasm-micro-runtime#1181

Impact

Testing

a wamr aot module tested on esp32. (with various other patches)
cxd56xx and esp32c3 are not tested.

Ouss4
Ouss4 approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@Ouss4 Ouss4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Although bytecodealliance/wasm-micro-runtime#1181 calls directly into arch code. We briefly discussed this before, and some ideas where mallopt and maybe also PROT_EXEC for mmap.

@yamt
Copy link
Contributor Author

yamt commented May 20, 2022

LGTM!

Although bytecodealliance/wasm-micro-runtime#1181 calls directly into arch code. We briefly discussed this before, and some ideas where mallopt and maybe also PROT_EXEC for mmap.

where was it discussed? i agree something more generic is nicer.

i considered to fix mmap. but it involves unnecessary overhead for this particular application.

@Ouss4
Copy link
Member

Ouss4 commented May 20, 2022

LGTM!
Although bytecodealliance/wasm-micro-runtime#1181 calls directly into arch code. We briefly discussed this before, and some ideas where mallopt and maybe also PROT_EXEC for mmap.

where was it discussed? i agree something more generic is nicer.

i considered to fix mmap. but it involves unnecessary overhead for this particular application.

Just internally, given the different regions ESP32 has.

@xiaoxiang781216 xiaoxiang781216 merged commit f2bc455 into apache:master May 20, 2022
wenyongh pushed a commit to bytecodealliance/wasm-micro-runtime that referenced this pull request May 23, 2022
@yamt
nuttx: Use text heap for executable memory (#1181)
723a808 
Based on nuttx patch "Add up_textheap_heapmember":
  apache/nuttx#6306
NingW101 pushed a commit to NingW101/wasm-micro-runtime that referenced this pull request Jul 19, 2022
@yamt @NingW101
nuttx: Use text heap for executable memory (bytecodealliance#1181)
30e932b 
Based on nuttx patch "Add up_textheap_heapmember":
  apache/nuttx#6306
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@yamt
nuttx: Use text heap for executable memory (bytecodealliance#1181)
6665d35 
Based on nuttx patch "Add up_textheap_heapmember":
  apache/nuttx#6306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@pkarashchenko pkarashchenko pkarashchenko approved these changes

@Ouss4 Ouss4 Ouss4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yamt @Ouss4 @pkarashchenko @xiaoxiang781216