drivers/wireless/gs2200m: Fix short bit length #6761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite being a mask variable for a 32-bit value, it was 16 bits long.
xiaoxiang781216
approved these changes
Aug 2, 2022
masayuki2009
approved these changes
Aug 2, 2022
pkarashchenko
approved these changes
Aug 2, 2022
| @@ -375,7 +375,7 @@ static bool _enable_cid(uint32_t *cid_bits, char cid, bool on) | |||
|
|
|||
| static bool _cid_is_set(uint32_t *cid_bits, char cid) | |||
| { | |||
| uint16_t mask = 1 << _cid_to_uint8(cid); | |||
| uint32_t mask = 1 << _cid_to_uint8(cid); | |||
There was a problem hiding this comment.
Optional
Suggested change
| uint32_t mask = 1 << _cid_to_uint8(cid); | |
| uint32_t mask = UINT32_C(1) << _cid_to_uint8(cid); |
| @@ -602,7 +602,7 @@ static void _remove_and_free_pkt(FAR struct gs2200m_dev_s *dev, uint8_t c) | |||
| static void _remove_all_pkt(FAR struct gs2200m_dev_s *dev, uint8_t c) | |||
| { | |||
| FAR struct pkt_dat_s *pkt_dat; | |||
| uint16_t mask; | |||
| uint32_t mask; | |||
|
|
|||
| mask = 1 << c; | |||
There was a problem hiding this comment.
Optional
Suggested change
| mask = 1 << c; | |
| mask = UINT32_C(1) << c; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Despite being a mask variable for a 32-bit value, it was 16 bits long.
Impact
GS2200M Wi-Fi driver
Testing
Operate telnetd and tcpserver at the same time on spresense by spresense:wifi config.