Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/wireless/gs2200m: Fix short bit length #6761

Merged
merged 1 commit into from
Aug 2, 2022
Merged

drivers/wireless/gs2200m: Fix short bit length #6761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions drivers/wireless/gs2200m.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ static bool _enable_cid(uint32_t *cid_bits, char cid, bool on)

static bool _cid_is_set(uint32_t *cid_bits, char cid)
{
uint16_t mask = 1 << _cid_to_uint8(cid);
uint32_t mask = 1 << _cid_to_uint8(cid);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional

Suggested change
uint32_t mask = 1 << _cid_to_uint8(cid);
uint32_t mask = UINT32_C(1) << _cid_to_uint8(cid);


if (*cid_bits & mask)
{
Expand Down Expand Up @@ -602,7 +602,7 @@ static void _remove_and_free_pkt(FAR struct gs2200m_dev_s *dev, uint8_t c)
static void _remove_all_pkt(FAR struct gs2200m_dev_s *dev, uint8_t c)
{
FAR struct pkt_dat_s *pkt_dat;
uint16_t mask;
uint32_t mask;

mask = 1 << c;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional

Suggested change
mask = 1 << c;
mask = UINT32_C(1) << c;

ASSERT(0 == (dev->valid_cid_bits & mask));
Expand Down