clang-tidy modernizations & clang-format reformat (#2012)

- Reformats according to tools/fix-format.sh:
Google style. Headers sorted -- except for a handful where
that resulted in errors. That part needs to be automated, and
isn't contained yet in `tools/fix-format.sh`
- adds a script to tools/ to generate compile_commands.json
  for clang_tidy.
- Ran some auto-fixes from clang-tidy-10:
```
    modernize-deprecated-headers
    modernize-make-shared
    modernize-make-unique
    modernize-use-default
    modernize-use-emplace
    modernize-use-nullptr
    modernize-use-override
    modernize-use-using
```

Should be a functional no-op, but not everything could be automated.

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>

.clang-format

@@ -1,15 +1,18 @@
 ---
-Language:        Cpp
-AccessModifierOffset: -2
-ColumnLimit: 100
+# Use the Google style in this project.
+BasedOnStyle: Google
+Language: Cpp
+AccessModifierOffset: -1
+ColumnLimit: 80
 DerivePointerAlignment: false
 PointerAlignment: Left
-SortIncludes: true
-...
-
+SortIncludes: false
+# This excludes multi-line comments, and with that
+# we leave license banners as-is
+CommentPragmas: "."
+ReflowComments: false
 ---
 Language: Proto
 ColumnLimit: 100
 SpacesInContainerLiterals: false
 AllowShortFunctionsOnASingleLine: false
-...

.gitignore

@@ -16,3 +16,4 @@ bazel-*
 .vscode/ipch
 .vscode/.vs_code_bazel_build/vs_code_aspect.bzl
 external/
+compile_commands.json

.vscode/c_cpp_properties.json

@@ -1,10 +1,21 @@
 {
-    "configurations": [
-      {
-        "name": "WSL",
-        "intelliSenseMode": "clang-x64",
-        "compilerPath": "/usr/bin/clang-8",
-        "includePath": [
+  "configurations": [
+    {
+      "name": "WSL",
+      "intelliSenseMode": "clang-x64",
+      "compilerPath": "/usr/lib/llvm-10/bin/clang-10",
+      "includePath": [
+        "${workspaceFolder}",
+        "${workspaceFolder}//bazel-incubator-pagespeed-mod/**",
+        "/usr/include/x86_64-linux-gnu/5/include",
+        "/usr/local/include",
+        "/usr/include/x86_64-linux-gnu/5/include-fixed",
+        "/usr/include/x86_64-linux-gnu",
+        "/usr/include"
+      ],
+      "defines": [],
+      "browse": {
+        "path": [
           "${workspaceFolder}",
           "${workspaceFolder}//bazel-incubator-pagespeed-mod/**",
           "/usr/include/x86_64-linux-gnu/5/include",
@@ -13,23 +24,13 @@
           "/usr/include/x86_64-linux-gnu",
           "/usr/include"
         ],
-        "defines": [],
-        "browse": {
-          "path": [
-            "${workspaceFolder}",
-            "${workspaceFolder}//bazel-incubator-pagespeed-mod/**",
-            "/usr/include/x86_64-linux-gnu/5/include",
-            "/usr/local/include",
-            "/usr/include/x86_64-linux-gnu/5/include-fixed",
-            "/usr/include/x86_64-linux-gnu",
-            "/usr/include"
-          ],
-          "limitSymbolsToIncludedHeaders": true,
-          "databaseFilename": ""
-        },
-        "cStandard": "c11",
-        "cppStandard": "c++14"
-      }
-    ],
-    "version": 4
-  }
+        "limitSymbolsToIncludedHeaders": true,
+        "databaseFilename": "compile_commands.json"
+      },
+      "cStandard": "c11",
+      "cppStandard": "c++17",
+      "compileCommands": "${workspaceFolder}/compile_commands.json"
+    }
+  ],
+  "version": 4
+}

base/logging.h

@@ -22,15 +22,13 @@
 #include "glog/logging.h"
 
 namespace logging {
-  constexpr int LOG_INFO = google::GLOG_INFO;
-  constexpr int LOG_ERROR = google::GLOG_ERROR;
-  constexpr int LOG_WARNING = google::GLOG_WARNING;
-  constexpr int LOG_FATAL = google::GLOG_FATAL;
-}
+constexpr int LOG_INFO = google::GLOG_INFO;
+constexpr int LOG_ERROR = google::GLOG_ERROR;
+constexpr int LOG_WARNING = google::GLOG_WARNING;
+constexpr int LOG_FATAL = google::GLOG_FATAL;
+}  // namespace logging
 
 // TODO(oschaaf): move this out of here.
-#ifndef DISALLOW_COPY_AND_ASSIGN
 #define DISALLOW_COPY_AND_ASSIGN(TypeName) \
-TypeName(const TypeName&);                 \
-void operator=(const TypeName&)
-#endif
+  TypeName(const TypeName&);               \
+  void operator=(const TypeName&)

mod_pagespeed.code-workspace

@@ -89,6 +89,9 @@
 			"regex": "cpp",
 			"set": "cpp",
 			"bit": "cpp"
-		}
+		},
+		"C_Cpp.clang_format_fallbackStyle": "Google",
+		"C_Cpp.clang_format_sortIncludes": true,
+		"editor.formatOnSave": true
 	}
 }