Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS minifier breaks unicode-range values #1572

Closed
peterbleickardt opened this issue Jun 27, 2017 · 1 comment
Closed

CSS minifier breaks unicode-range values #1572

peterbleickardt opened this issue Jun 27, 2017 · 1 comment

Comments

@peterbleickardt
Copy link

@peterbleickardt peterbleickardt commented Jun 27, 2017

What steps will reproduce the problem?

  1. Activate CSS minification in mod_pagespeed
  2. Include a unicode-range CSS declaration in a stylesheet: unicode-range: U+0400-045F, U+0490-0491, U+04B0-04B1, U+2116

What is the expected output?
unicode-range:U+0400-045F, U+0490-0491, U+04B0-04B1, U+2116

What do you see instead?
The CSS minification output breaks the value, placing a space between the 'U' and '+':

unicode-range:U +0400-045F , U +0490-0491 , U +04B0-04B1 , U +2116

This prevents the browser from seeing the proper value, therefore always downloading the font even if the intended range of characters is not used.

What version of the product are you using?
X-Mod-Pagespeed: 1.11.33.4-0

Which OS? Which version of Apache? Which MPM?
CentOS, Apache/2.2.27 (prefork)

@jmarantz
Copy link
Contributor

@jmarantz jmarantz commented Jun 27, 2017

Thanks for the report. For quick workaround, I suggest using ModPagespeedDisallow to avoid processing the CSS file with the unicode characters. Hopefully this (a) doesn't affect all of them and (b) maybe you could split it just the rules that have this.

I'll check into what the status of this is. A few things are fixed in 1.12 (that's now stable) however this one doesn't ring a bell.

ashishk-1 added a commit to ashishk-1/incubator-pagespeed-mod that referenced this issue Aug 11, 2017
@oschaaf oschaaf closed this in 2fb25bc Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants