This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
LoadFromFileCacheTtlMs is not honored (*after* first request) #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not ready to go in yet, needs more verification of code paths. Fixes apache/incubator-pagespeed-ngx#1418
oschaaf
force-pushed
the
oschaaf-nps-issue-1418
branch
from
ed5ed3d
to
5555d21
Compare
jmarantz
reviewed
Jun 2, 2017
|
|
||
| // Determine if we need to use the implicit cache ttl ms or the implicit | ||
| // load from file cache ttl ms. | ||
| int64 implicit_ttl = Options()->implicit_cache_ttl_ms(); |
There was a problem hiding this comment.
implicit_ttl_ms (paranoid about units I am :)
|
@jmarantz I changed an existing unit test, WDYT? |
oschaaf
commented
Jun 3, 2017
| @@ -454,6 +461,16 @@ void InPlaceRewriteContext::RemoveRedundantRelCanonicalHeader( | |||
| ResponseHeaders::RelCanonicalHeaderValue(url_)); | |||
| } | |||
|
|
|||
| bool InPlaceRewriteContext::IsLoadFromFileBased() { | |||
|
Hi @oschaaf. Does this mean it's in master already? I'm new here. Strike that. I just read... |
|
@0x42h It's not in master yet, this code change is currently under review. If everyone is happy with it it will get merged to master. |
jmarantz
approved these changes
Jun 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-pagespeed-ngx#1418