This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Redis: Use Redis DB-Index when computing the SystemCache lookup key #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(off course, CI is till broken, working on figuring out how to fix that) |
oschaaf
force-pushed
the
oschaaf-redis-dbindex-fix
branch
from
2847bab
to
57fd347
Compare
|
(rebased this PR so we can hopefully observe how CI feels about this change ) |
|
checkin tests not passing. It seems that REDIS_PORT is set as an environment variable, when we're not actually running the tests with redis. (I was assuming that wouldn't be the case) |
oschaaf
force-pushed
the
oschaaf-redis-dbindex-fix
branch
from
57fd347
to
fae4a11
Compare
|
Disabled the test. I need to dive in to the specifics of |
|
Merging this as-is in to solve this issue, I will file a separate issue on the REDIS_PORT being set when tests are run without redis. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added test didn't turn out the way I planned to because of running into some unrelated
things (see the comment in the test script).
The full checkin tests are still running, but I did observe the added test itself to pass.
Should fix #1771