This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
log: initialize logging earlier #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out to be possible to initialize logging earlier by grabbing the log from a global ngx_cycle structure. This makes us start logging earlier, yet loses the "No threading detected ..." messages both from stderr and in error.log when nginx initially starts. With this change, these messages will now be logged as we start logging earlier: " flush . " These originate from SystemCachePath::CacheKey which appends newlines to the key, and the resulting cache key ends up being logged. We might want to change that, because the resulting lines in error.log look weird and might raise questions. Fixes #895
|
LGTM Looks good. I'll fix the cache path key issue having newlines on the mps side. |
jeffkaufman
added a commit
that referenced
this pull request
Dec 17, 2015
…bug-noise log: initialize logging earlier
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out to be possible to initialize logging earlier by
grabbing the log from a global ngx_cycle structure.
This makes us start logging earlier, yet loses the
"No threading detected ..." messages both from stderr and
in error.log when nginx initially starts.
With this change, these messages will now be logged as we start
logging earlier:
"
flush
.
"
These originate from SystemCachePath::CacheKey which appends
newlines to the key, and the resulting cache key ends up being
logged. We might want to change that (on the mps side), because the resulting
lines in error.log look weird and might raise questions.
Fixes #895