fix(duplication): fix the dangling pointer after blob object is moved
#2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empiredan
changed the title
empiredan
force-pushed
the
fix-add-mutation-if-valid
branch
from
aa205c7
to
5c85045
Compare
acelyc111
reviewed
Aug 9, 2024
| bb = std::move(update.data); | ||
| } else { | ||
| bb = blob::create_from_bytes(update.data.data(), update.data.length()); | ||
| } |
There was a problem hiding this comment.
While it's possible the _holder is nullptr and _data has a valid data pointer, so it's needed to process the latter case.
empiredan
changed the title
blob object is moved
|
Good work! Could you please rebase the latest master branch to check if there are any clang-tidy warnings or errors. You don't have to fix all the warnings/errors, some rules can be disabled after discussion. |
acelyc111
reviewed
Aug 12, 2024
empiredan
force-pushed
the
fix-add-mutation-if-valid
branch
from
5162b8a
to
cd0fab0
Compare
acelyc111
previously approved these changes
Aug 14, 2024
empiredan
force-pushed
the
fix-add-mutation-if-valid
branch
from
3129063
to
cadf722
Compare
acelyc111
approved these changes
Aug 14, 2024
foreverneverer
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2089
Refactor
blobobject to avoid the dangling pointer leading to heap-use-after-freeerror which happened in #2089 after
blobobject is moved. Also refactor and addsome tests for
blobandmutation_batch.