-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(duplication): fix the dangling pointer after blob
object is moved
#2088
fix(duplication): fix the dangling pointer after blob
object is moved
#2088
Conversation
aa205c7
to
5c85045
Compare
bb = std::move(update.data); | ||
} else { | ||
bb = blob::create_from_bytes(update.data.data(), update.data.length()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's possible the _holder
is nullptr and _data
has a valid data pointer, so it's needed to process the latter case.
blob
object is moved
Good work! Could you please rebase the latest master branch to check if there are any clang-tidy warnings or errors. You don't have to fix all the warnings/errors, some rules can be disabled after discussion. |
5162b8a
to
cd0fab0
Compare
3129063
to
cadf722
Compare
#2089
Refactor
blob
object to avoid the dangling pointer leading to heap-use-after-freeerror which happened in #2089 after
blob
object is moved. Also refactor and addsome tests for
blob
andmutation_batch
.