Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fd: fix failure detection bug #247

Merged
merged 7 commits into from
Jan 7, 2019
Merged

fd: fix failure detection bug #247

merged 7 commits into from
Jan 7, 2019

Conversation

hycdong
Copy link
Contributor

@hycdong hycdong commented Jan 7, 2019

issue #239 and issue #189

  • fix failure detection bug
  • expand fd lease time
  • expand rolling update interval

@hycdong hycdong added the type/bug-fix This PR fixes a bug. label Jan 7, 2019
@qinzuoyan
Copy link
Contributor

src/server/config-server.ini 中也改成：

    fd_check_interval_seconds = 2
    fd_beacon_interval_seconds = 3
    fd_lease_seconds = 20
    fd_grace_seconds = 22

@qinzuoyan
Copy link
Contributor

另外更新下 rdsn

@qinzuoyan qinzuoyan merged commit e62f02c into apache:master Jan 7, 2019
qinzuoyan pushed a commit that referenced this pull request Feb 27, 2019
@hycdong @qinzuoyan
fd: fix failure detection bug (#247)
b2854f5
neverchanje pushed a commit to neverchanje/pegasus that referenced this pull request Jul 13, 2019
@hycdong @qinzuoyan
fd: fix failure detection bug (apache#247)
f3e017e 
Former-commit-id: 176fb260862d173481f22bdca257aab7b4ae30a9 [formerly e62f02c]
Former-commit-id: c70a547f739ffb96e911f6e2534c5c3c06053011
@hycdong hycdong deleted the fd branch June 3, 2020 06:58
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
maintenance: record p99 rpc byte size (#247)
8379453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinzuoyan qinzuoyan qinzuoyan approved these changes

@vagetablechicken vagetablechicken vagetablechicken approved these changes

@acelyc111 acelyc111 Awaiting requested review from acelyc111

@mentoswang mentoswang Awaiting requested review from mentoswang

@neverchanje neverchanje Awaiting requested review from neverchanje

@zhangyifan27 zhangyifan27 Awaiting requested review from zhangyifan27

Assignees
No one assigned
Labels
type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hycdong @qinzuoyan @vagetablechicken