Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hotspot): new algorithm of hotspot detection #479

Merged
merged 226 commits into from
Mar 5, 2020
Merged

feat(hotspot): new algorithm of hotspot detection #479

merged 226 commits into from
Mar 5, 2020

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented Feb 19, 2020 •
edited

What problem does this PR solve?

According to #477

What is changed and how it works?

It is a strategy of hotspot detection #444
Compared to the previous algorithm, it makes the following improvements:

  1. It defined the concept of threshold, and ready for automatic monitoring.
  2. It has higher stability

Result

  1. no hotspot, single set/single get
    微信截图_20200221134449
  2. one hotspot, single set/single get
    微信截图_20200221132757
  3. two hotspot, single set/single get
    微信截图_20200221144307
  4. three hotspot, single set/single get
    微信截图_20200221142337
    5 one hotspot, multiget

New Configuration:

[pegasus.collector]
  hotspot_detect_algorithm = hotspot_algo_qps_variance # default = hotspot_algo_qps_variance

acelyc111
acelyc111 reviewed Mar 5, 2020
View reviewed changes
src/server/info_collector.cpp Outdated Show resolved Hide resolved
src/server/info_collector.cpp Outdated Show resolved Hide resolved
src/server/info_collector.cpp Outdated Show resolved Hide resolved
acelyc111
acelyc111 reviewed Mar 5, 2020
View reviewed changes
src/server/info_collector.cpp Outdated Show resolved Hide resolved
src/server/info_collector.cpp Outdated Show resolved Hide resolved
src/server/info_collector.cpp Outdated Show resolved Hide resolved
@Smityz @acelyc111
Update src/server/info_collector.cpp
1d9e6c2 
Co-Authored-By: Yingchun Lai <405403881@qq.com>
acelyc111
acelyc111 previously approved these changes Mar 5, 2020
View reviewed changes
@Smityz Smityz merged commit a0ddab2 into apache:master Mar 5, 2020
@Smityz Smityz mentioned this pull request Mar 11, 2020
Closed
@Smityz Smityz deleted the hotspot branch March 12, 2020 10:28
@neverchanje neverchanje mentioned this pull request Mar 31, 2020
Closed
@neverchanje neverchanje added the type/config-change Added or modified configuration that should be noted on release note of new version. label Mar 31, 2020
neverchanje pushed a commit that referenced this pull request Mar 31, 2020
@Smityz
feat(hotspot): new algorithm of hotspot detection (#479)
19dae33
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
@hycdong
feat(bulk-load): bulk load download part4 - replica report download s…
c682bf1 
…tatus and progress (#479)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acelyc111 acelyc111 acelyc111 approved these changes

@levy5307 levy5307 levy5307 approved these changes

Assignees
No one assigned
Labels
1.12.3 type/config-change Added or modified configuration that should be noted on release note of new version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Smityz @acelyc111 @levy5307 @neverchanje