Couple of copy contructor and/or assignment operator missing. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for you propose. Because the RocksDB project is forked from facebook/rocksdb, so I think you'd better send pull request to facebook/rocksdb firstly. |
acelyc111
pushed a commit
that referenced
this pull request
Apr 26, 2022
cauchy1988
pushed a commit
to cauchy1988/incubator-pegasus
that referenced
this pull request
May 9, 2022
cauchy1988
pushed a commit
to cauchy1988/incubator-pegasus
that referenced
this pull request
May 12, 2022
* add more API docstring
acelyc111
pushed a commit
that referenced
this pull request
May 26, 2022
bugfix: revert pr#3 and fix connections being closed during TableConn…
acelyc111
pushed a commit
that referenced
this pull request
May 26, 2022
fix meta session re-connection bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule of three:
https://en.wikipedia.org/wiki/Rule_of_three_%28C%2B%2B_programming%29