-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
what to do about file/src/test/resources/nested-sample.tar ? #320
Comments
@Claudenw there is a test that relies on nested-sample.tar. The tar file has a complicated structure and the test wants this. I've read https://www.apache.org/legal/release-policy.html and when ASF bans compiled binaries from source releases - nested-sample.tar is not a compiled binary so IMHO this file is ok for inclusion in the source release. |
I swear we had a discussion before about this file and it was resolved, no? |
I can't find any previous discussions about this file. I think we have discussed other binary data files in other repos and I think generally, we've been able to remove them. This one isn't as easy to remove. |
Now I remember, it was a discussion about binary files and this tile was mentioned and we had to demonstrate it wasn't a binary file |
Some of the items I listed can be fixed by adding headers, others I think
can be addressed by adding README or other documentation in the directory
tree where the problematic files are listed. This is how I would address
the sample.tar file; create a document that explains what it is for and
perhaps points to the test.
q: can you add files to the tar or is the test that picky? i.e. can you
add a LICENSE and README file to the tar?
…On Sat, Jan 20, 2024 at 10:19 PM Matthew de Detrich < ***@***.***> wrote:
Now I remember, it was a discussion about binary files and this tile was
mentioned and we had to demonstrate it wasn't a binary file
—
Reply to this email directly, view it on GitHub
<#320 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASTVHSF2ZOQVVO67OM4MR3YPQYHDAVCNFSM6AAAAABCDI2Y62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGI3DONBTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
LinkedIn: http://www.linkedin.com/in/claudewarren
|
@Claudenw The file was created by Akka team. Why do we need to add license to it? The ASF have no claim to ownership of the file. Akka didn't bother claiming ownership of the file. I will argue this over and over. |
@Claudenw My memory is coming back now and I am fairly sure that this file was already reviewed with a fine tooth comb by @justinmclean some time ago and it hasn't change since then. |
Used in a unit test.
The text was updated successfully, but these errors were encountered: