[REEF-807] Set JVM max memory limit used in testsuites properly #540

dongjoon-hyun · 2015-10-04T14:47:01Z

This PR upgrades Maven surefire plugin and sets the proper value of JVM
max memory limit for it in order to recover JDK 1.7 Apache Jenkins builds.

JIRA:
REEF-807

Pull Request:
This closes #

dongjoon-hyun · 2015-10-06T01:03:04Z

Hi, @taegeonum . Could you merge this PR? I think you are the best person to merge this. :)

taegeonum · 2015-10-06T01:54:00Z

@dongjoon-hyun It looks good to me. I will merge it.

bchocho · 2015-10-06T01:55:04Z

@taegeonum can we test it on the build servers with java 1.7?

taegeonum · 2015-10-06T02:07:07Z

@dafrista Yes. But, I found that the root cause of the OutOfMemory error is because of the outdated java 1.7 version in Jenkins. When I changed the java 1.7 to different version of 1.7 in Jenkins, the OOM is resolved.

However, regardless of the OOM, I think it is valuable to change surefire version to latest version and set the max memory limit.

bchocho · 2015-10-06T02:12:08Z

That's interesting. Just for the record, what version of 1.7 is/was causing problems? It would be nice to have that information in case others run into this problem.

I agree these changes are good regardless of the OOM. It would be even nicer to confirm that they solve the issue the JIRA was originally for.

taegeonum · 2015-10-06T02:21:57Z

@dafrista Unfortunately, I don't know the exact version causing the problem. Jenkins just shows /home/jenkins/tools/java/latest1.7/bin/java ( It looks like latest1.7 is not current latest version)

When I changed the java from latest1.7 to /home/jenkins/jenkins-slave/tools/hudson.model.JDK/jdk-1.7u51/bin/java, OOM is resolved.

bchocho · 2015-10-06T02:26:08Z

Thanks. Does the OOM still appear with this fix running latest1.7?

taegeonum · 2015-10-06T02:31:16Z

@dafrista Yes, it is. I think it would be good to change the contents of the issue REEF-807, because it is not actually resolve the OOM. @dongjoon-hyun What do you think?

dongjoon-hyun · 2015-10-06T02:33:03Z

Could you point out OOM log in Apache Jenkins with latest JDK 1.7?

dongjoon-hyun · 2015-10-06T02:36:26Z

@taegeonum , I can not find correct build log. As I reported yesterday, the rebuild command in Jenkins does not apply my patch. Please look at the most recent log.

https://builds.apache.org/job/Reef-pull-request-ubuntu/637/consoleFull

dongjoon-hyun · 2015-10-06T02:40:35Z

I'm sure that my patch will resolve that issue. Could you test correctly again?

The following two build is just building master branch. (You can see surefire version is 1.7, not 1.8.1 in my patch)

https://builds.apache.org/job/Reef-pull-request-ubuntu/637/consoleFull
(/home/jenkins/jenkins-slave/tools/hudson.model.JDK/jdk-1.7u51/bin/java)

https://builds.apache.org/job/Reef-pull-request-ubuntu/636/consoleFull (/home/jenkins/tools/java/latest1.7/bin/java)

dongjoon-hyun · 2015-10-06T02:49:08Z

I leave some comments in Github.

For the recording purpose, I'm sure that my patch resolve that issue
correctly. Could you test again?

The following your builds are just building master branch.
You can see surefire version is 1.7, not 1.8.1 in my patch.

https://builds.apache.org/job/Reef-pull-request-ubuntu/637/consoleFull
(/home/jenkins/jenkins-slave/tools/hudson.model.JDK/jdk-1.7u51/bin/java)

https://builds.apache.org/job/Reef-pull-request-ubuntu/636/consoleFull

(/home/jenkins/tools/java/latest1.7/bin/java)

Warmly,

Dongjoon.

On Tue, Oct 6, 2015 at 11:31 AM, Tae-Geon Um notifications@github.com
wrote:

@dafrista https://github.com/dafrista Yes, it is. I think it would be
good to change the contents of the issue REEF-807, because it is not
actually resolve the OOM. @dongjoon-hyun
https://github.com/dongjoon-hyun What do you think?

—
Reply to this email directly or view it on GitHub
#540 (comment)
.

taegeonum · 2015-10-06T03:18:04Z

@dongjoon-hyun Thanks! As you pointed, the rebuild is not working correctly. I will let you know if is resolved.

dongjoon-hyun · 2015-10-06T05:00:35Z

Hi, Tae-Geon. I think I can help you.

Could you guide me to get a login id for Apache Jenkins?

Dongjoon.

On Tue, Oct 6, 2015 at 12:18 PM, Tae-Geon Um notifications@github.com
wrote:

@dongjoon-hyun https://github.com/dongjoon-hyun Thanks! As you pointed,
the rebuild is not working correctly. I will let you know if is resolved.

—
Reply to this email directly or view it on GitHub
#540 (comment)
.

taegeonum · 2015-10-06T05:18:37Z

Thanks a lot!
According to https://wiki.apache.org/general/Jenkins, you should ask our PMC chair to execute the command:

modify_appgroups.pl hudson-jobadmin --add=<Apache username>

Hi Chris,

Could you help Dongjoon to get a Jenkins account?

Thanks,
Taegeon

On Oct 6, 2015, at 2:00 PM, Dongjoon Hyun notifications@github.com wrote:

Hi, Tae-Geon. I think I can help you.

Could you guide me to get a login id for Apache Jenkins?

Dongjoon.

On Tue, Oct 6, 2015 at 12:18 PM, Tae-Geon Um notifications@github.com
wrote:

@dongjoon-hyun https://github.com/dongjoon-hyun Thanks! As you pointed,
the rebuild is not working correctly. I will let you know if is resolved.

—
Reply to this email directly or view it on GitHub
#540 (comment)
.

—
Reply to this email directly or view it on GitHub #540 (comment).

dongjoon-hyun · 2015-10-06T05:40:11Z

Thank you. I think I had better send an email him directly.
By the way, Chris Douglas or Chris Mattmann?

taegeonum · 2015-10-06T06:32:55Z

Chris Douglas.
I’ve already sent the email to him.

FYI: I’ve got an email from apache build team. It seems that pull request plugin is not working with rebuild.

Begin forwarded message:

From: Andrew Bayer andrew.bayer@gmail.com
Subject: Re: Jenkins rebuild does not build same branch?
Date: October 6, 2015 at 3:21:50 PM GMT+9
To: "builds@apache.org" builds@apache.org
Reply-To: builds@apache.org

The pull request plugin is a bit weird with rebuilds - I'll investigate to
see if I can find more details.

On Tuesday, October 6, 2015, Tae-Geon Um taegeonum@gmail.com wrote:

Hi all,

When I triggered rebuild, the rebuild does not build same branch.

In the origin pull request build,
https://builds.apache.org/job/Reef-pull-request-ubuntu/629/ <
https://builds.apache.org/job/Reef-pull-request-ubuntu/629/>
Merging refs/tags/changes/629

git rev-parse refs/tags/changes/629^{commit} # timeout=10
git merge 7ff182a # timeout=10
git rev-parse master^{commit} # timeout=10
Checking out Revision 7ff182a (master)
git config core.sparsecheckout # timeout=10
git checkout -f 7ff182a
git rev-parse origin/master^{commit} # timeout=10
git rev-list b9b8dca # timeout=10

It checks out 7ff182a

However, when I rebuilt the pull request,
https://builds.apache.org/job/Reef-pull-request-ubuntu/634/
Checking out Revision b9b8dca
(origin/master)

git config core.sparsecheckout # timeout=10
git checkout -f b9b8dca
git rev-list b9b8dca # timeout=10

It checks out b9b8dca

Is there anyone who knows the reason?

Thanks in advance.
Taegeon.

On Oct 6, 2015, at 2:40 PM, Dongjoon Hyun notifications@github.com wrote:

Thank you. I think I had better send an email him directly.
By the way, Chris Douglas or Chris Mattmann?

—
Reply to this email directly or view it on GitHub #540 (comment).

taegeonum · 2015-10-06T06:40:52Z

Thanks a lot. :)

On Tuesday, 6 October 2015, Tae-Geon Um taegeonum@gmail.com wrote:

Chris Douglas.
I’ve already sent the email to him.

FYI: I’ve got an email from apache build team. It seems that pull request
plugin is not working with rebuild.

Begin forwarded message:

_From: *Andrew Bayer <andrew.bayer@gmail.com
javascript:_e(%7B%7D,'cvml','andrew.bayer@gmail.com');>
*Subject: _Re: Jenkins rebuild does not build same branch?
*Date: *October 6, 2015 at 3:21:50 PM GMT+9
*To: *"builds@apache.org
javascript:_e(%7B%7D,'cvml','builds@apache.org');" <builds@apache.org
javascript:_e(%7B%7D,'cvml','builds@apache.org');>
*Reply-To: *builds@apache.org
javascript:_e(%7B%7D,'cvml','builds@apache.org');

The pull request plugin is a bit weird with rebuilds - I'll investigate to
see if I can find more details.

On Tuesday, October 6, 2015, Tae-Geon Um <taegeonum@gmail.com
javascript:_e(%7B%7D,'cvml','taegeonum@gmail.com');> wrote:

Hi all,

When I triggered rebuild, the rebuild does not build same branch.

In the origin pull request build,
https://builds.apache.org/job/Reef-pull-request-ubuntu/629/ <
https://builds.apache.org/job/Reef-pull-request-ubuntu/629/>
Merging refs/tags/changes/629

git rev-parse refs/tags/changes/629^{commit} # timeout=10
git merge 7ff182a # timeout=10
git rev-parse master^{commit} # timeout=10

Checking out Revision 7ff182a (master)

git config core.sparsecheckout # timeout=10
git checkout -f 7ff182a
git rev-parse origin/master^{commit} # timeout=10
git rev-list b9b8dca # timeout=10

It checks out 7ff182a

However, when I rebuilt the pull request,
https://builds.apache.org/job/Reef-pull-request-ubuntu/634/
Checking out Revision b9b8dca
(origin/master)

git config core.sparsecheckout # timeout=10
git checkout -f b9b8dca
git rev-list b9b8dca # timeout=10

It checks out b9b8dca

Is there anyone who knows the reason?

Thanks in advance.
Taegeon.

On Oct 6, 2015, at 2:40 PM, Dongjoon Hyun <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Thank you. I think I had better send an email him directly.
By the way, Chris Douglas or Chris Mattmann?

—
Reply to this email directly or view it on GitHub
#540 (comment)
.

taegeonum · 2015-10-06T18:28:43Z

Done -C

On Mon, Oct 5, 2015 at 10:18 PM, Tae-Geon Um taegeonum@gmail.com wrote:

Thanks a lot!
According to https://wiki.apache.org/general/Jenkins, you should ask our
PMC chair to execute the command:
modify_appgroups.pl hudson-jobadmin --add=<Apache username>
Hi Chris,

Could you help Dongjoon to get a Jenkins account?

Thanks,
Taegeon

On Oct 6, 2015, at 2:00 PM, Dongjoon Hyun notifications@github.com
wrote:

Hi, Tae-Geon. I think I can help you.

Could you guide me to get a login id for Apache Jenkins?

Dongjoon.

On Tue, Oct 6, 2015 at 12:18 PM, Tae-Geon Um notifications@github.com
wrote:

@dongjoon-hyun https://github.com/dongjoon-hyun Thanks! As you
pointed,
the rebuild is not working correctly. I will let you know if is resolved.

—
Reply to this email directly or view it on GitHub
<
https://github.com/apache/incubator-reef/pull/540#issuecomment-145730966>
.

—
Reply to this email directly or view it on GitHub
#540 (comment)
.

dongjoon-hyun · 2015-10-07T04:41:09Z

Thank you, Chris.
I can login into Jenkins, now.

dongjoon-hyun · 2015-10-07T05:19:12Z

Hi, @taegeonum and @dafrista .
I found that current configuration is different with https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin .
I'm starting to reconfigure Jenkins. It will cause several build messages.

dongjoon-hyun · 2015-10-07T06:15:54Z

Jenkins, retest this please.

dongjoon-hyun · 2015-10-07T06:33:23Z

Rebased to trigger.

This PR upgrades Maven surefire plugin and sets the proper value of JVM max memory limit for it in order to recover JDK 1.7 Apache Jenkins builds. JIRA: [REEF-807](https://issues.apache.org/jira/browse/REEF-807) Pull Request: This closes apache#540

dongjoon-hyun · 2015-10-07T07:54:27Z

Hi, @dafrista and @taegeonum .

I finished the following tests successfully. Now, we can run REEF tests safely.

https://builds.apache.org/job/Reef-pull-request-ubuntu/660/consoleText
(/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7/bin/java)

https://builds.apache.org/job/Reef-pull-request-ubuntu/659/consoleText
/home/jenkins/jenkins-slave/tools/hudson.model.JDK/jdk-1.7u51/bin/java

Could any one of you merge this PR now? :)

By the way, 'Rebuild' button is still have problem. I will keep my eyes on that, too.

taegeonum · 2015-10-07T07:56:51Z

@dongjoon-hyun Great! Thanks a lot! I will happily merge this pull request :)

dongjoon-hyun · 2015-10-07T07:58:07Z

Thank you, @taegeonum . :)

dongjoon-hyun force-pushed the REEF-807 branch from 7ff182a to 71583cf Compare October 7, 2015 06:29

dongjoon-hyun force-pushed the REEF-807 branch from 71583cf to 33fecd1 Compare October 7, 2015 06:54

asfgit closed this in 9a93935 Oct 7, 2015

dongjoon-hyun deleted the REEF-807 branch October 9, 2015 01:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[REEF-807] Set JVM max memory limit used in testsuites properly #540

[REEF-807] Set JVM max memory limit used in testsuites properly #540

dongjoon-hyun commented Oct 4, 2015

dongjoon-hyun commented Oct 6, 2015

taegeonum commented Oct 6, 2015

bchocho commented Oct 6, 2015

taegeonum commented Oct 6, 2015

bchocho commented Oct 6, 2015

taegeonum commented Oct 6, 2015

bchocho commented Oct 6, 2015

taegeonum commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

taegeonum commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

taegeonum commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

taegeonum commented Oct 6, 2015

taegeonum commented Oct 6, 2015

taegeonum commented Oct 6, 2015

dongjoon-hyun commented Oct 7, 2015

dongjoon-hyun commented Oct 7, 2015

dongjoon-hyun commented Oct 7, 2015

dongjoon-hyun commented Oct 7, 2015

dongjoon-hyun commented Oct 7, 2015

taegeonum commented Oct 7, 2015

dongjoon-hyun commented Oct 7, 2015

[REEF-807] Set JVM max memory limit used in testsuites properly #540

[REEF-807] Set JVM max memory limit used in testsuites properly #540

Conversation

dongjoon-hyun commented Oct 4, 2015

dongjoon-hyun commented Oct 6, 2015

taegeonum commented Oct 6, 2015

bchocho commented Oct 6, 2015

taegeonum commented Oct 6, 2015

bchocho commented Oct 6, 2015

taegeonum commented Oct 6, 2015

bchocho commented Oct 6, 2015

taegeonum commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

taegeonum commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

taegeonum commented Oct 6, 2015

dongjoon-hyun commented Oct 6, 2015

taegeonum commented Oct 6, 2015

taegeonum commented Oct 6, 2015

taegeonum commented Oct 6, 2015

dongjoon-hyun commented Oct 7, 2015

dongjoon-hyun commented Oct 7, 2015

dongjoon-hyun commented Oct 7, 2015

dongjoon-hyun commented Oct 7, 2015

dongjoon-hyun commented Oct 7, 2015

taegeonum commented Oct 7, 2015

dongjoon-hyun commented Oct 7, 2015