Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary copy of bytes. resolve #1085 #1087

Merged
merged 4 commits into from
May 26, 2019
Merged

Remove unnecessary copy of bytes. resolve #1085 #1087

merged 4 commits into from
May 26, 2019

Conversation

kezhenxu94
Copy link
Member

Ⅰ. Describe what this PR did

Remove unnecessary copy of bytes.

Ⅱ. Does this pull request fix one issue?

resolve #1085

@codecov-io
Copy link

codecov-io commented May 22, 2019 •
edited
Loading

Codecov Report

Merging #1087 into develop will increase coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1087      +/-   ##
=============================================
+ Coverage      41.71%   41.87%   +0.15%     
  Complexity      1361     1361              
=============================================
  Files            243      243              
  Lines          10113    10106       -7     
  Branches        1319     1319              
=============================================
+ Hits            4219     4232      +13     
+ Misses          5348     5327      -21     
- Partials         546      547       +1
Impacted Files Coverage Δ Complexity Δ
...a/io/seata/core/rpc/netty/MessageCodecHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (+4.52%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027fefe...7cf3036. Read the comment docs.

leizhiyuan
leizhiyuan approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leizhiyuan leizhiyuan added this to the 0.6.0 milestone May 22, 2019
slievrly
slievrly approved these changes May 25, 2019
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangthen zhangthen merged commit b52ad6d into apache:develop May 26, 2019
@kezhenxu94 kezhenxu94 deleted the gh1085 branch May 26, 2019 03:32
@fescar-robot fescar-robot mentioned this pull request May 31, 2019
Closed
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@kezhenxu94 @nick-tan
Remove unnecessary copy of bytes. resolve apache#1085 (apache#1087)
876781f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leizhiyuan leizhiyuan leizhiyuan approved these changes

@slievrly slievrly slievrly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.*
Development

Successfully merging this pull request may close these issues.

Unnecessary copying bytes
7 participants
@kezhenxu94 @codecov-io @leizhiyuan @slievrly @zhangthen @xingfudeshi @ujjboy