We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
there are many operations like:
https://github.com/seata/seata/blob/b7a930d0528030caca53c811d740703e3f676e94/core/src/main/java/io/seata/core/rpc/netty/MessageCodecHandler.java#L80-L82
in class io.seata.core.rpc.netty.MessageCodecHandler, which copies the bytes over and over, and it can just be replaced with:
io.seata.core.rpc.netty.MessageCodecHandler
out.writeBytes(byteBuffer);
if it makes sense to you, I'll send a PR to fix this, thanks :)
no unnecessary copies
The text was updated successfully, but these errors were encountered:
@kezhenxu94 it makes sense.
Sorry, something went wrong.
Remove unnecessary copy of bytes. resolve #1085 (#1087)
b52ad6d
Remove unnecessary copy of bytes. resolve apache#1085 (apache#1087)
876781f
kezhenxu94
Successfully merging a pull request may close this issue.
Ⅰ. Issue Description
there are many operations like:
https://github.com/seata/seata/blob/b7a930d0528030caca53c811d740703e3f676e94/core/src/main/java/io/seata/core/rpc/netty/MessageCodecHandler.java#L80-L82
in class
io.seata.core.rpc.netty.MessageCodecHandler
, which copies the bytes over and over, and it can just be replaced with:if it makes sense to you, I'll send a PR to fix this, thanks :)
Ⅲ. Describe what you expected to happen
no unnecessary copies
The text was updated successfully, but these errors were encountered: