-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support metrics for tc server #1236
Conversation
Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>
Metrics is record by MetricsSubscriber that listening Transaction Status Changed events from EventBus |
Codecov Report
@@ Coverage Diff @@
## develop #1236 +/- ##
=============================================
+ Coverage 44.96% 45.36% +0.39%
- Complexity 1488 1511 +23
=============================================
Files 253 256 +3
Lines 10279 10354 +75
Branches 1337 1338 +1
=============================================
+ Hits 4622 4697 +75
- Misses 5069 5073 +4
+ Partials 588 584 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the next version,I hope to add a Mertic configuration node and load the SPI through the configuration in the configuration file, such as which type of exporter to load.
Sounds good, I will try it later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: zhengyangyong yangyong.zheng@qq.com
Ⅰ. Describe what this PR did
make tc support metrics and add default prometheus publisher
Ⅱ. Does this pull request fix one issue?
#384
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
https://seata.io/zh-cn/docs/ops/operation.html (need update later)
Ⅴ. Special notes for reviews