Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support metrics for tc server #1236

Merged
merged 3 commits into from
Jun 26, 2019
Merged

Conversation

zhengyangyong
Copy link
Contributor

Signed-off-by: zhengyangyong yangyong.zheng@qq.com

Ⅰ. Describe what this PR did

make tc support metrics and add default prometheus publisher

Ⅱ. Does this pull request fix one issue?

#384

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

https://seata.io/zh-cn/docs/ops/operation.html (need update later)

Ⅴ. Special notes for reviews

Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>
@zhengyangyong
Copy link
Contributor Author

Metrics is record by MetricsSubscriber that listening Transaction Status Changed events from EventBus
Event Bus Mechanism PR : #768

@codecov-io
Copy link

codecov-io commented Jun 24, 2019

Codecov Report

Merging #1236 into develop will increase coverage by 0.39%.
The diff coverage is 82.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1236      +/-   ##
=============================================
+ Coverage      44.96%   45.36%   +0.39%     
- Complexity      1488     1511      +23     
=============================================
  Files            253      256       +3     
  Lines          10279    10354      +75     
  Branches        1337     1338       +1     
=============================================
+ Hits            4622     4697      +75     
- Misses          5069     5073       +4     
+ Partials         588      584       -4
Impacted Files Coverage Δ Complexity Δ
server/src/main/java/io/seata/server/Server.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/io/seata/server/metrics/MetricsSubscriber.java 73.52% <73.52%> (ø) 6 <6> (?)
...n/java/io/seata/server/metrics/MetricsManager.java 81.81% <81.81%> (ø) 5 <5> (?)
...java/io/seata/server/metrics/MeterIdConstants.java 96.55% <96.55%> (ø) 1 <1> (?)
...server/store/file/FileTransactionStoreManager.java 45.99% <0%> (-1.05%) 19% <0%> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.77% <0%> (-0.79%) 24% <0%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 55.15% <0%> (+3.6%) 26% <0%> (+3%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007ed0b...7ea74af. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the next version,I hope to add a Mertic configuration node and load the SPI through the configuration in the configuration file, such as which type of exporter to load.

@zhengyangyong
Copy link
Contributor Author

Sounds good, I will try it later

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
function valid

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit 1911ae4 into apache:develop Jun 26, 2019
@leizhiyuan leizhiyuan modified the milestone: 0.7.0 Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants