#751 add event bus mechanism and apply it in tc #768

zhengyangyong · 2019-04-11T08:59:25Z

Signed-off-by: zhengyangyong yangyong.zheng@qq.com

codecov-io · 2019-04-11T09:03:45Z

Codecov Report

❗ No coverage uploaded for pull request base (develop@7fefe47). Click here to learn what that means.
The diff coverage is 65.9%.

@@            Coverage Diff             @@
##             develop     #768   +/-   ##
==========================================
  Coverage           ?   43.91%           
  Complexity         ?     1447           
==========================================
  Files              ?      253           
  Lines              ?    10262           
  Branches           ?     1332           
==========================================
  Hits               ?     4507           
  Misses             ?     5173           
  Partials           ?      582

Impacted Files	Coverage Δ	Complexity Δ
...va/io/seata/core/event/GlobalTransactionEvent.java	`0% <0%> (ø)`	`0 <0> (?)`
.../java/io/seata/server/coordinator/DefaultCore.java	`60.35% <100%> (ø)`	`24 <9> (?)`
...o/seata/server/coordinator/DefaultCoordinator.java	`51.54% <100%> (ø)`	`23 <0> (?)`
...c/main/java/io/seata/core/event/GuavaEventBus.java	`100% <100%> (ø)`	`4 <4> (?)`
...in/java/io/seata/server/event/EventBusManager.java	`66.66% <66.66%> (ø)`	`1 <1> (?)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fefe47...ec7637b. Read the comment docs.

CoffeeLatte007

Is th pull request for monitoring ？There are two more points to consider:
1.server shutdown or close ,the data will be lost.Whether the data should be persisted and split by day?
2.Whether retrycommit, retryRollback and timeout need to monitored

server/src/test/java/com/alibaba/fescar/server/coordinator/TransactionEventListener.java

core/src/main/java/com/alibaba/fescar/core/event/GuavaEventBus.java

zhengyangyong · 2019-04-11T10:32:11Z

Is th pull request for monitoring ？There are two more points to consider:
1.server shutdown or close ,the data will be lost.Whether the data should be persisted and split by day?
2.Whether retrycommit, retryRollback and timeout need to monitored

because it is a event bus, I think persistence is not necessary
yes it is a good suggestion I will try add them

zhengyangyong · 2019-04-12T03:15:29Z

Move raise start,commit and rollback event code from DefaultCoordinator to DefaultCore in order to ensure retrycommit and retryRollback monitored
Add timeout event in DefaultCoordinator

CoffeeLatte007

LGTM

leizhiyuan · 2019-04-19T01:22:45Z

core/src/main/java/io/seata/core/event/GuavaEventBus.java

+  }
+
+  @Override
+  public void register(Object object) {


maybe Event should be a custom interface， not object， we can limit the type of event。

Good suggestion, done

leizhiyuan · 2019-04-22T04:06:32Z

LGTM

xingfudeshi · 2019-05-17T08:02:53Z

@zhengyangyong there are errors need to be solved.

Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

…ltCoordinator to DefaultCore in order to ensure retrycommit and retryRollback;add timeout event in DefaultCoordinator Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

… of event Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

slievrly · 2019-06-18T10:21:17Z

server/src/main/java/io/seata/server/event/GlobalTransactionEvent.java

+import io.seata.core.event.Event;
+import io.seata.core.model.GlobalStatus;
+
+public class GlobalTransactionEvent implements Event {


Is it more appropriate to move to the core module?

yes,you are right, Done

slievrly · 2019-06-18T10:23:04Z

server/src/test/resources/file.conf

@@ -0,0 +1,5 @@
+#reduce delay for test


Is it necessary?

yes ,this file is for test (in test resources folder) in order to reduce asyn-committing-retry-delay (default is 30 second) and timeout-retry-delay (default is 30 second) , then we can fast check event with TimeoutRollbacking status come from core.

slievrly · 2019-06-18T10:24:05Z

server/src/test/resources/registry.conf

@@ -0,0 +1,7 @@
+config {


Is it necessary?
It seems that it is not consistent with the configuration file of the main project.

same as above

slievrly

For the new file, add the author info.

…m server to core module Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

zhengyangyong · 2019-06-19T13:15:08Z

All new file had add author info

slievrly

LGTM

xingfudeshi

LGTM

CoffeeLatte007 reviewed Apr 11, 2019

View reviewed changes

server/src/test/java/com/alibaba/fescar/server/coordinator/TransactionEventListener.java Outdated Show resolved Hide resolved

core/src/main/java/com/alibaba/fescar/core/event/GuavaEventBus.java Outdated Show resolved Hide resolved

zhengyangyong force-pushed the tc_event_bus branch 2 times, most recently from 6f8e141 to 83aa6a7 Compare April 18, 2019 07:10

CoffeeLatte007 approved these changes Apr 18, 2019

View reviewed changes

leizhiyuan reviewed Apr 19, 2019

View reviewed changes

zhengyangyong force-pushed the tc_event_bus branch 2 times, most recently from 4456284 to 8527afe Compare April 22, 2019 01:49

slievrly mentioned this pull request May 18, 2019

Support OpenTracing 2.0 to get tracing and metrics capabilities #884

Open

zhengyangyong closed this Jun 5, 2019

slievrly reopened this Jun 13, 2019

slievrly added this to the 0.7.0 milestone Jun 13, 2019

zhengyangyong added 4 commits June 13, 2019 18:12

apache#751 add event bus mechanism and apply it in tc

538229f

Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

apache#751 move raise start,commit and rollback event code from Defau…

4bed224

…ltCoordinator to DefaultCore in order to ensure retrycommit and retryRollback;add timeout event in DefaultCoordinator Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

apache#751 rebased and change package from fescar to seata

127ab96

Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

apache#751 rebased and add Event interface in order to limit the type…

17eb3f4

… of event Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

zhengyangyong force-pushed the tc_event_bus branch from b265795 to 065b858 Compare June 13, 2019 15:38

apache#751 rebased resolve conflict and format the code

89c5ec0

Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

zhengyangyong force-pushed the tc_event_bus branch from 065b858 to 89c5ec0 Compare June 13, 2019 16:02

zhengyangyong added 2 commits June 15, 2019 16:14

Merge branch 'develop' into tc_event_bus

a7ad69f

Merge branch 'develop' into tc_event_bus

7cd42af

slievrly reviewed Jun 18, 2019

View reviewed changes

zhengyangyong added 2 commits June 19, 2019 20:50

Merge branch 'develop' into tc_event_bus

8985e53

apache#751 add author in new file and move GlobalTransactionEvent fro…

e73d1c6

…m server to core module Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>

slievrly approved these changes Jun 19, 2019

View reviewed changes

Merge branch 'develop' into tc_event_bus

ec7637b

xingfudeshi approved these changes Jun 19, 2019

View reviewed changes

slievrly merged commit a7d3e72 into apache:develop Jun 20, 2019

fescar-robot mentioned this pull request Jun 21, 2019

[WeeklyReport] Weekly report for Seata 2019-6-14 to 2019-6-21 #1231

Closed

zhengyangyong mentioned this pull request Jun 24, 2019

support metrics for tc server #1236

Merged

nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019

add event bus mechanism and apply it in tc (apache#768)

0fecd4c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#751 add event bus mechanism and apply it in tc #768

#751 add event bus mechanism and apply it in tc #768

zhengyangyong commented Apr 11, 2019

codecov-io commented Apr 11, 2019 •

edited

CoffeeLatte007 left a comment

zhengyangyong commented Apr 11, 2019

zhengyangyong commented Apr 12, 2019

CoffeeLatte007 left a comment

leizhiyuan Apr 19, 2019

zhengyangyong Apr 19, 2019 •

edited

leizhiyuan commented Apr 22, 2019

xingfudeshi commented May 17, 2019

slievrly Jun 18, 2019

zhengyangyong Jun 19, 2019

slievrly Jun 18, 2019

zhengyangyong Jun 19, 2019 •

edited

slievrly Jun 18, 2019

zhengyangyong Jun 19, 2019

slievrly left a comment

zhengyangyong commented Jun 19, 2019

slievrly left a comment

xingfudeshi left a comment

#751 add event bus mechanism and apply it in tc #768

#751 add event bus mechanism and apply it in tc #768

Conversation

zhengyangyong commented Apr 11, 2019

codecov-io commented Apr 11, 2019 • edited

Codecov Report

CoffeeLatte007 left a comment

Choose a reason for hiding this comment

zhengyangyong commented Apr 11, 2019

zhengyangyong commented Apr 12, 2019

CoffeeLatte007 left a comment

Choose a reason for hiding this comment

leizhiyuan Apr 19, 2019

Choose a reason for hiding this comment

zhengyangyong Apr 19, 2019 • edited

Choose a reason for hiding this comment

leizhiyuan commented Apr 22, 2019

xingfudeshi commented May 17, 2019

slievrly Jun 18, 2019

Choose a reason for hiding this comment

zhengyangyong Jun 19, 2019

Choose a reason for hiding this comment

slievrly Jun 18, 2019

Choose a reason for hiding this comment

zhengyangyong Jun 19, 2019 • edited

Choose a reason for hiding this comment

slievrly Jun 18, 2019

Choose a reason for hiding this comment

zhengyangyong Jun 19, 2019

Choose a reason for hiding this comment

slievrly left a comment

Choose a reason for hiding this comment

zhengyangyong commented Jun 19, 2019

slievrly left a comment

Choose a reason for hiding this comment

xingfudeshi left a comment

Choose a reason for hiding this comment

codecov-io commented Apr 11, 2019 •

edited

zhengyangyong Apr 19, 2019 •

edited

zhengyangyong Jun 19, 2019 •

edited