-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support -Dkey=value SysConfig #1379
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1379 +/- ##
==========================================
Coverage 45.96% 45.96%
Complexity 1695 1695
==========================================
Files 345 345
Lines 12485 12485
Branches 1596 1596
==========================================
Hits 5739 5739
Misses 6092 6092
Partials 654 654 Continue to review full report at Codecov.
|
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Show resolved
Hide resolved
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Show resolved
Hide resolved
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
support -Dkey=value parameter
startup parameter > -D parameter > configCenter parameter > default value
Ⅱ. Does this pull request fix one issue?
fix #1377
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews