feature: isolate druid used in rm-datasource to solve druid compatibility issue #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggndnn
force-pushed
the
feature_isolate_druid
branch
4 times, most recently
from
3e8d22d
to
6453aea
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1693 +/- ##
=============================================
- Coverage 50.14% 50.11% -0.03%
- Complexity 2664 2665 +1
=============================================
Files 517 517
Lines 17016 17038 +22
Branches 2063 2065 +2
=============================================
+ Hits 8532 8538 +6
- Misses 7674 7688 +14
- Partials 810 812 +2
|
ggndnn
force-pushed
the
feature_isolate_druid
branch
from
6453aea
to
75314f1
Compare
|
Good! |
ggndnn
force-pushed
the
feature_isolate_druid
branch
2 times, most recently
from
8e620af
to
c6ae681
Compare
slievrly
changed the title
ggndnn
force-pushed
the
feature_isolate_druid
branch
from
c6ae681
to
f8a5de5
Compare
|
Wait #1703 merged. |
ggndnn
force-pushed
the
feature_isolate_druid
branch
from
f8a5de5
to
755c35e
Compare
ggndnn
changed the title
ggndnn
force-pushed
the
feature_isolate_druid
branch
2 times, most recently
from
b7cc9b7
to
b9993ba
Compare
ggndnn
force-pushed
the
feature_isolate_druid
branch
6 times, most recently
from
65358c3
to
b71f94f
Compare
xingfudeshi
reviewed
Feb 12, 2020
sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/DefaultDruidLoader.java
Outdated
Show resolved
Hide resolved
ggndnn
force-pushed
the
feature_isolate_druid
branch
from
0291064
to
7b0cb53
Compare
ggndnn
force-pushed
the
feature_isolate_druid
branch
from
fac7262
to
de76e16
Compare
ggndnn
force-pushed
the
feature_isolate_druid
branch
from
de76e16
to
2501d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This PR was created to to solve druid compatibility issue, because druid was only used to do sql parser, so all druid related code were isolated from users' druid by a separate class loader. All imports from druid in rm-datasource were removed except unit test code. In addition, sql parser part was extracted to several new projects as SPI, e.g., seata-sqlparser-core and seata-sqlparser-druid.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews