refactor: create sql parser spi and a druid type sql parser #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1703 +/- ##
=============================================
- Coverage 54.38% 54.38% -0.01%
- Complexity 2459 2461 +2
=============================================
Files 445 445
Lines 14860 14858 -2
Branches 1765 1764 -1
=============================================
- Hits 8082 8080 -2
Misses 6001 6001
Partials 777 777
|
jsbxyyx
reviewed
Sep 26, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMeta.java
Outdated
Show resolved
Hide resolved
jsbxyyx
reviewed
Sep 26, 2019
...ta-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/oracle/OracleInsertRecognizer.java
Outdated
Show resolved
Hide resolved
ggndnn
force-pushed
the
refactor_sqlparser_spi
branch
from
15e4ece
to
6dff95d
Compare
ggndnn
force-pushed
the
refactor_sqlparser_spi
branch
4 times, most recently
from
de996aa
to
cb27e2f
Compare
ggndnn
force-pushed
the
refactor_sqlparser_spi
branch
2 times, most recently
from
ccf5acc
to
d77fb59
Compare
ggndnn
force-pushed
the
refactor_sqlparser_spi
branch
from
99a9eb3
to
35ae2de
Compare
|
@ggndnn please fix the conflict |
Ok, I will fix it. |
ggndnn
force-pushed
the
refactor_sqlparser_spi
branch
from
fa7542c
to
af5e5bd
Compare
|
@lovepoem fixed. |
zjinlei
reviewed
Jan 3, 2020
core/src/main/java/io/seata/core/constants/ConfigurationKeys.java
Outdated
Show resolved
Hide resolved
ggndnn
force-pushed
the
refactor_sqlparser_spi
branch
from
ead1212
to
bfea9f0
Compare
slievrly
reviewed
Jan 7, 2020
rm-datasource/src/main/java/io/seata/rm/datasource/sql/SQLVisitorFactory.java
Show resolved
Hide resolved
dangquocbang
pushed a commit
to dangquocbang/seata
that referenced
this pull request
Jan 14, 2020
* 'develop' of https://github.com/seata/seata: (125 commits) optimize: tcc module code style (apache#2103) refactor: change the package path of MySQL recognizer (apache#2125) optimize: fix query typo (apache#2176) refactor: add sql parser type druid as constant (apache#2156) test: enhance test coverage of seata common (apache#2170) optimize: gracefully close resources (apache#2139) Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. (apache#2151) chore:use serializer instead of codec (apache#2097) optimize: spring module code style (apache#2159) optimize: Add Dubbo compatibility (apache#2036) optimize : seata-rm-datasource module code style (apache#2062) bugfix: Saga report branch status incorrect when service retried succeed (apache#2145) optimize:optimize log specifications (apache#2146) bugfix: when branchRollback failed, it will trigger retry of multi-tc. (apache#2113) refactor: create sql parser spi and a druid type sql parser (apache#1703) refactor: simplify to make seata-common more readable (apache#2038) feature: support FastThreadLocalContextCore (apache#2106) optimize: some typos (apache#2120) optimize: increase the oracle table meta cache code coverage (apache#2078) optimize: some typos (apache#2115) ... # Conflicts: # pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This PR extracted sql parser part from rm-datasource to create sql parser SPI (seata-sqlparser-core), all imports from druid in rm-datasource were removed except unit test code. Druid related code was moved to a new project seata-sqlparser-druid where a druid type sql parser was implemented.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews