bugfix: clean up resources in time to avoid mutual influence between unit tests #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1778 +/- ##
============================================
+ Coverage 50.42% 50.73% +0.3%
- Complexity 2153 2161 +8
============================================
Files 414 414
Lines 14151 14151
Branches 1700 1700
============================================
+ Hits 7136 7179 +43
+ Misses 6328 6283 -45
- Partials 687 689 +2
Continue to review full report at Codecov.
|
dangquocbang
pushed a commit
to dangquocbang/seata
that referenced
this pull request
Oct 22, 2019
* 'develop' of https://github.com/seata/seata: feature:support gRpc (apache#1492) bugfix:fix auto proxy for multiple-datasource does not work (apache#1793) optimize: increase rm code coverage by db mock (apache#1674) bugfix: mysql can not get primary key value (apache#1788) bugfix: jdk 11 remoteAddress is null (apache#1764) test: verify that the analysis of the cause of issue 1702 is correct (apache#1710) optimize: seata server register eureka instance id (apache#1790) optimize: put message to logQueue (apache#1760) optimize:optimize rpc remoting log(apache#1787) optimize: simplify code (apache#1786) version: change version to 1.0.0-SNAPSHOT (apache#1785) bugfix: clean up resources in time to avoid mutual influence between unit tests (apache#1778) optimize:remove unused method (apache#1766) bugfix: DeleteExecutor. buildBeforeImageSQL keyword checker by db type (apache#1777) optimize: string splice and release lock (apache#1770) release 0.9.0 (apache#1771) bugfix: oracle rollback failed when the table has null Blob Clob value (apache#1761) bugfix: service method not support interface type parameter (apache#1759) optimize: abstract table meta cache (apache#1750) optimize: improve the efficiency of the batch log (apache#1743)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
According to #1710's ci output,
DefaultCoreForEventBusTest's threadAsyncCommitting_2_1committedDefaultCoreForEventBusTest's session, so it's proved that more than oneAsyncCommittingthreads running in the same time which could case the unit test failure.This PR tried to clean up unit tests' resources to avoid mutual influence between them.
DefaultCoordinatorMetricsTest:
DefaultCoreForEventBusTest:
Ⅱ. Does this pull request fix one issue?
fixes #1702
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews