Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: seata server register eureka instance id #1790

Merged
merged 4 commits into from
Oct 19, 2019
Merged

optimize: seata server register eureka instance id #1790

merged 4 commits into from
Oct 19, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Oct 18, 2019

Ⅰ. Describe what this PR did

seata server register eureka instance id appName:ip:port to ip:appName:port

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 18, 2019

Codecov Report

Merging #1790 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1790      +/-   ##
=============================================
- Coverage      50.71%   50.68%   -0.03%     
  Complexity      2160     2160              
=============================================
  Files            414      414              
  Lines          14153    14153              
  Branches        1700     1700              
=============================================
- Hits            7177     7174       -3     
- Misses          6285     6287       +2     
- Partials         691      692       +1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 59.21% <0%> (-0.99%) 29% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36cbe51...c78dcae. Read the comment docs.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei merged commit b78f425 into apache:develop Oct 19, 2019
l81893521 pushed a commit to l81893521/seata that referenced this pull request Oct 22, 2019
dangquocbang pushed a commit to dangquocbang/seata that referenced this pull request Oct 22, 2019
* 'develop' of https://github.com/seata/seata:
  feature:support gRpc (apache#1492)
  bugfix:fix auto proxy for multiple-datasource does not work (apache#1793)
  optimize: increase rm code coverage by db mock (apache#1674)
  bugfix: mysql can not get primary key value (apache#1788)
  bugfix: jdk 11 remoteAddress is null (apache#1764)
  test: verify that the analysis of the cause of issue 1702 is correct (apache#1710)
  optimize: seata server register eureka instance id (apache#1790)
  optimize: put message to logQueue (apache#1760)
  optimize:optimize rpc remoting log(apache#1787)
  optimize: simplify code (apache#1786)
  version: change version to 1.0.0-SNAPSHOT (apache#1785)
  bugfix: clean up resources in time to avoid mutual influence between unit tests (apache#1778)
  optimize:remove unused method (apache#1766)
  bugfix: DeleteExecutor. buildBeforeImageSQL keyword checker by db type (apache#1777)
  optimize: string splice and release lock (apache#1770)
  release 0.9.0 (apache#1771)
  bugfix: oracle rollback failed when the table has null Blob Clob value (apache#1761)
  bugfix: service method not support interface type parameter (apache#1759)
  optimize: abstract table meta cache (apache#1750)
  optimize: improve the efficiency of the batch log (apache#1743)
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants