Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix NPE in UndoExecutorFactory #1902

Merged
merged 29 commits into from
Nov 15, 2019
Merged

Conversation

booogu
Copy link
Contributor

@booogu booogu commented Nov 14, 2019

Ⅰ. Describe what this PR did

fix a minor NPE bug:
Swapped the order of constant and variable in a equals() method call

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Hao Zhibei and others added 29 commits November 9, 2019 11:11
@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #1902 into develop will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1902      +/-   ##
=============================================
+ Coverage      55.41%   55.43%   +0.01%     
- Complexity      2406     2410       +4     
=============================================
  Files            428      428              
  Lines          14346    14346              
  Branches        1699     1699              
=============================================
+ Hits            7950     7952       +2     
  Misses          5679     5679              
+ Partials         717      715       -2
Impacted Files Coverage Δ Complexity Δ
.../seata/rm/datasource/undo/UndoExecutorFactory.java 64.28% <0%> (ø) 3 <3> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 48.41% <0%> (+0.39%) 30% <0%> (+3%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit c72cd97 into apache:develop Nov 15, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants