bugfix:A class with private access constructors should not be loaded by SPI. #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1927 +/- ##
============================================
+ Coverage 55.29% 55.3% +0.01%
Complexity 2408 2408
============================================
Files 429 429
Lines 14279 14278 -1
Branches 1676 1676
============================================
+ Hits 7895 7897 +2
+ Misses 5676 5673 -3
Partials 708 708
|
xingfudeshi
reviewed
Nov 22, 2019
common/src/main/java/io/seata/common/loader/EnhancedServiceLoader.java
Outdated
Show resolved
Hide resolved
xingfudeshi
changed the title
@xingfudeshi |
|
@jsbxyyx @xingfudeshi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Fix a bug that will appear when the class has default private constructor
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews