feature: support to set propagation of global transaction #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjinlei
reviewed
Jan 20, 2020
zjinlei
reviewed
Jan 21, 2020
booogu
force-pushed
the
f_propagation1
branch
from
dbc51c6
to
d304b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Supports 4 propagations of transaction:
(1) REQUIRED: Use existing transaction context or if not, begin a new transaction (the default propagation)
(2) REQUIRES_NEW: Begin a new transaction context.
(3) NOT_SUPPORTED: exclude the existing transaction context.
(4) SUPPORTS: If there is a transaction, join the transaction; if there is no transaction, execute it in a non transactional way
Ⅱ. Does this pull request fix one issue?
fixed #1515
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews