-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:correct wrong property names in seata-spring-boot-starter. #2217
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2217 +/- ##
=============================================
- Coverage 54.2% 53.95% -0.25%
- Complexity 2623 2624 +1
=============================================
Files 489 489
Lines 15339 15340 +1
Branches 1750 1751 +1
=============================================
- Hits 8314 8277 -37
- Misses 6241 6282 +41
+ Partials 784 781 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to modify the SpringBootConfigurationProvider#convertDataId
, convert the configuration items -
to Camel
style configuration. This pr will conflict with #2182 .
These changes correspond to the structure in file.conf, where each {} is a properties class. |
And the data id conversion is required only if the properties in the properties class are read. |
TestName and test-name are equivalent when reading a configuration item in spring boot. |
Such as there is a |
fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...c/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java
Show resolved
Hide resolved
...c/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java
Show resolved
Hide resolved
...c/main/java/io/seata/spring/boot/autoconfigure/provider/SpringBootConfigurationProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Corret wrong property names in seata-spring-boot-starter.
Ⅱ. Does this pull request fix one issue?
fixes #2114
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done integration testing.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews