optimize: optimize PreparedStatementProxy initialization logic #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CharmingRabbit please resolve conflict. |
Codecov Report
@@ Coverage Diff @@
## develop #2242 +/- ##
=============================================
- Coverage 50.22% 50.16% -0.06%
Complexity 3026 3026
=============================================
Files 598 598
Lines 19314 19311 -3
Branches 2348 2347 -1
=============================================
- Hits 9700 9688 -12
- Misses 8652 8664 +12
+ Partials 962 959 -3
|
|
slievrly
reviewed
Jul 1, 2020
| @@ -50,7 +50,7 @@ public OracleOutputVisitor createOutputVisitor(final ParametersHolder parameters | |||
| @Override | |||
| public boolean visit(SQLVariantRefExpr x) { | |||
| if ("?".equals(x.getName())) { | |||
| ArrayList<Object> oneParamValues = parametersHolder.getParameters()[x.getIndex()]; | |||
| ArrayList<Object> oneParamValues = parametersHolder.getParameters().get(x.getIndex()); | |||
There was a problem hiding this comment.
Corrected，please take a look.
l81893521
added
module/rm-datasource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Change the data structure of ParameterHolder from 2 Dimension Array to Map so that we don't need to execute getParameterCount() while initializing PreparedStatementProxy,which will execute an additional business independent SQL query.
A further explanation of the present deficiencies:
If the ParameterHolder uses ArrayList as storage structure, the method "targetStatement.getParameterMetaData ().getparametercount()" will be executed when initializing parameterholder to determine the size of the ArrayList. In some database drivers (such as postgressql), this method will execute a database query, which will lead to performance degradation. In addition, this method may throw a SQLException , if that happen , the Exception that was thrown before the real business SQL will lead to an error that is hard to understand for the users.
Ⅱ. Does this pull request fix one issue?
fixes #2394
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews