Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: adjust the processing logic for unsupported listeners #2354

Merged
merged 5 commits into from
Mar 5, 2020

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

adjust the processing logic for unsupported listeners

Ⅱ. Does this pull request fix one issue?

#2335

@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #2354 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2354      +/-   ##
=============================================
- Coverage      51.62%   51.62%   -0.01%     
  Complexity      2693     2693              
=============================================
  Files            517      517              
  Lines          16728    16728              
  Branches        2038     2038              
=============================================
- Hits            8636     8635       -1     
  Misses          7284     7284              
- Partials         808      809       +1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 56.19% <0%> (-0.32%) 29% <0%> (ø)

@funky-eyes
Copy link
Contributor Author

@zjinlei @slievrly PTAL

@funky-eyes funky-eyes changed the title bugfix:adjust the processing logic for unsupported listeners optimize:adjust the processing logic for unsupported listeners Mar 5, 2020
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title optimize:adjust the processing logic for unsupported listeners optimize: adjust the processing logic for unsupported listeners Mar 5, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 917bfc7 into apache:develop Mar 5, 2020
funky-eyes added a commit to funky-eyes/seata that referenced this pull request Mar 5, 2020
optimize: adjust the processing logic for unsupported listeners (apache#2354)
@slievrly slievrly added this to the 1.2.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants