Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support password decryption #2667

Merged
merged 48 commits into from
Dec 30, 2020

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

support druid encryption and decryption

Ⅱ. Does this pull request fix one issue?

fix #2665

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title feature: support druid encryption and decryption [WIP] feature: support druid encryption and decryption May 9, 2020
@l81893521 l81893521 added the module/core core module label May 20, 2020
@slievrly slievrly changed the title [WIP] feature: support druid encryption and decryption feature: support druid encryption and decryption Jun 23, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2020

Codecov Report

Merging #2667 into develop will decrease coverage by 0.16%.
The diff coverage is 31.68%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2667      +/-   ##
=============================================
- Coverage      50.37%   50.21%   -0.17%     
- Complexity      3116     3123       +7     
=============================================
  Files            594      595       +1     
  Lines          19625    19699      +74     
  Branches        2438     2410      -28     
=============================================
+ Hits            9887     9892       +5     
- Misses          8744     8788      +44     
- Partials         994     1019      +25     
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...eata/core/store/db/AbstractDataSourceProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...seata/server/storage/redis/JedisPooledFactory.java 31.25% <0.00%> (-8.75%) 4.00 <0.00> (ø)
...rc/main/java/io/seata/common/util/ConfigTools.java 54.23% <54.23%> (ø) 9.00 <9.00> (?)
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (-5.27%) 3.00% <0.00%> (ø%)
... and 20 more

@funky-eyes funky-eyes requested a review from slievrly June 23, 2020 14:49
@funky-eyes funky-eyes changed the title feature: support druid encryption and decryption feature: support database password decryption Jun 27, 2020
@caohdgege
Copy link
Contributor

add publicKey to config.txt

@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #2667 (268e12b) into develop (9e9ba4b) will decrease coverage by 0.03%.
The diff coverage is 31.68%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2667      +/-   ##
=============================================
- Coverage      51.69%   51.66%   -0.04%     
- Complexity      3344     3354      +10     
=============================================
  Files            617      618       +1     
  Lines          20265    20340      +75     
  Branches        2539     2543       +4     
=============================================
+ Hits           10477    10509      +32     
- Misses          8737     8780      +43     
  Partials        1051     1051              
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...eata/core/store/db/AbstractDataSourceProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...seata/server/storage/redis/JedisPooledFactory.java 21.27% <0.00%> (-3.73%) 4.00 <0.00> (ø)
...rc/main/java/io/seata/common/util/ConfigTools.java 54.23% <54.23%> (ø) 9.00 <9.00> (?)

@funky-eyes funky-eyes removed this from the 1.4.0 milestone Oct 21, 2020
@funky-eyes funky-eyes added this to the 1.5.0 milestone Nov 7, 2020
@funky-eyes funky-eyes changed the title feature: support database password decryption feature: support password decryption Dec 30, 2020
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @caohdgege

@quanqiuchaoren
Copy link

你们好,我看所有关于加解密的都会被引导到这个地方,但是我没有在这个地方找到如何进行加解密的方式,或许这个文章中提到了一些关键词,但是我对这个方面的知识比较少,目前还是不知道怎么加解密,如果有人知道的话,请告知具体的方式,感谢

@quanqiuchaoren
Copy link

Hello, I see that everything about encryption and decryption leads to this place, but I didn't find how to encrypt and decrypt in this place. Maybe there are some keywords mentioned in this article, but I have little knowledge about this. I still don't know how to encrypt and decrypt. If anyone knows, please tell me how. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/core core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file.conf配置数据库密码不支持加密
8 participants