Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:register the participating companies and pull request information #3637

Merged
merged 25 commits into from
Apr 23, 2021

Conversation

lj2018110133
Copy link
Contributor

…ion,etc

Ⅰ. Describe what this PR did

register the participating companies 、 pull request information、modify rootcontext,etc

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@lj2018110133 lj2018110133 changed the title Optimize:register the participating companies 、 pull request informat… optimize:register the participating companies and pull request information Apr 15, 2021
changes/en-us/1.4.2.md Outdated Show resolved Hide resolved
changes/1.4.2.md Outdated Show resolved Hide resolved
@funky-eyes funky-eyes added this to the 1.4.2 milestone Apr 16, 2021
@codecov-io
Copy link

codecov-io commented Apr 16, 2021

Codecov Report

Merging #3637 (ee42208) into develop (aa17303) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3637      +/-   ##
=============================================
- Coverage      52.09%   52.08%   -0.01%     
- Complexity      3511     3512       +1     
=============================================
  Files            638      638              
  Lines          21147    21147              
  Branches        2629     2629              
=============================================
- Hits           11016    11015       -1     
- Misses          9044     9046       +2     
+ Partials        1087     1086       -1     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/core/context/RootContext.java 48.27% <0.00%> (ø) 19.00 <0.00> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) 11.00% <0.00%> (-1.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.47% <0.00%> (+0.43%) 76.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 53.02% <0.00%> (+0.46%) 29.00% <0.00%> (+1.00%)

core/src/main/java/io/seata/core/context/RootContext.java Outdated Show resolved Hide resolved
core/src/main/java/io/seata/core/context/RootContext.java Outdated Show resolved Hide resolved
@@ -137,7 +137,7 @@ public static String unbind() {
String xid = (String) CONTEXT_HOLDER.remove(KEY_XID);
if (xid != null) {
if (LOGGER.isInfoEnabled()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isInfoEnabled -> isDebugEnabled

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2021

Codecov Report

Merging #3637 (454ff0d) into develop (c091e69) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 454ff0d differs from pull request most recent head 79f1a43. Consider uploading reports for the commit 79f1a43 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3637      +/-   ##
=============================================
+ Coverage      51.91%   51.92%   +0.01%     
- Complexity      3500     3501       +1     
=============================================
  Files            639      639              
  Lines          21181    21181              
  Branches        2634     2634              
=============================================
+ Hits           10996    10999       +3     
+ Misses          9091     9089       -2     
+ Partials        1094     1093       -1     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/core/context/RootContext.java 48.27% <0.00%> (ø) 19.00 <0.00> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) 12.00% <0.00%> (+1.00%)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slievrly
Copy link
Member

#3359 move to test module

@slievrly
Copy link
Member

#3500 修复 oracle 和 postgreSql 无法获取 column info 的问题。

@slievrly
Copy link
Member

#3402 修复更新SQL中字段名含有库名无法解析更新列的问题。

@slievrly
Copy link
Member

#3236 优化执行解锁操作的条件,减少不必要的 unlock 操作。

@slievrly
Copy link
Member

#3116 支持配置 apollo 配置中心配置 configService 和 cluster。

@slievrly
Copy link
Member

#3516 支持 consul 作为注册中心和配置中心时的 acl-token

@slievrly
Copy link
Member

#3228 支持自定义序列化插件。

@slievrly
Copy link
Member

#2933 支持mysql antlr sqlparser

@slievrly
Copy link
Member

#3531 修复RedisTransactionStoreManager 获取 brachTransaction 可能的 NPE 问题。

@slievrly
Copy link
Member

#3533 支持获取当前事务角色。

@slievrly
Copy link
Member

#3540 修复server发布打包时缺失文件的问题。

@slievrly
Copy link
Member

#3513 Saga SpringBeanService调用器支持切换 json 解析器。

@slievrly
Copy link
Member

#3549 统一DB存储模式下不同表中的xid字段的长度。

@slievrly
Copy link
Member

#3560 修复 Committing 状态的事务异步任务没有时间阈值和无法进行事务恢复的问题。

@slievrly
Copy link
Member

#3317 支持当zookeeper作为配置中心时从单node获取全部配置。

@slievrly
Copy link
Member

#3578 move to test module。

@slievrly
Copy link
Member

#3574 move to optimize module。

@slievrly
Copy link
Member

#3573 move to optimize module。

@slievrly
Copy link
Member

#3579 添加 StringFormatUtils 测试用例。

@slievrly
Copy link
Member

#3597 修复可能的 NPE问题。

@slievrly
Copy link
Member

#3607 修复 EventBus 的单元测试问题。

@slievrly
Copy link
Member

#3631 优化 nacos-config.py 脚本的入参问题。

@slievrly
Copy link
Member

#3522 修复当 DML 影响行数为0时注册分支和插入undo_log的问题。

@slievrly
Copy link
Member

#3635 修复zookeeper 配置变更无法推送通知的问题。

@slievrly
Copy link
Member

#3638 优化 update 和 delete 的 SQL 不支持 join 的错误提示。

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit faa1b7d into apache:develop Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants