Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Saga support jackson json parser #2831

Merged
merged 9 commits into from
Jul 1, 2020

Conversation

long187
Copy link
Contributor

@long187 long187 commented Jun 24, 2020

Ⅰ. Describe what this PR did

Saga support jackson json parser

Ⅳ. Describe how to verify it

client {
  rm {
    sagaJsonParser = jackson
  }
}

or

client {
  rm {
    sagaJsonParser = fastjson
  }
}

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #2831 into develop will increase coverage by 0.03%.
The diff coverage is 66.05%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2831      +/-   ##
=============================================
+ Coverage      50.09%   50.13%   +0.03%     
- Complexity      2960     2973      +13     
=============================================
  Files            594      597       +3     
  Lines          19015    19071      +56     
  Branches        2291     2297       +6     
=============================================
+ Hits            9526     9561      +35     
- Misses          8545     8558      +13     
- Partials         944      952       +8     
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...in/java/io/seata/core/constants/DefaultValues.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...o/seata/saga/statelang/domain/DomainConstants.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../statelang/parser/impl/StateMachineParserImpl.java 62.74% <33.33%> (-5.44%) 8.00 <6.00> (ø)
...ata/saga/statelang/parser/impl/FastjsonParser.java 50.00% <50.00%> (ø) 4.00 <4.00> (?)
.../saga/statelang/parser/impl/JacksonJsonParser.java 51.85% <51.85%> (ø) 4.00 <4.00> (?)
...tatelang/parser/utils/DesignerJsonTransformer.java 54.38% <77.35%> (-0.65%) 24.00 <19.00> (ø)
...seata/saga/statelang/parser/JsonParserFactory.java 90.00% <90.00%> (ø) 3.00 <3.00> (?)
... and 3 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title Saga support jackson json parser feature: Saga support jackson json parser Jun 24, 2020
@slievrly slievrly added the module/saga saga module label Jun 25, 2020
@wangliang181230
Copy link
Contributor

wangliang181230 commented Jun 28, 2020

Would it be better to Seata support jackson json parser? Not just SAGA mode.

@funky-eyes
Copy link
Contributor

please resolve code conflicts

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @wangliang1986

@funky-eyes
Copy link
Contributor

please resolve code conflicts

@long187
Copy link
Contributor Author

long187 commented Jul 1, 2020

please resolve code conflicts

done

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 8caac90 into apache:develop Jul 1, 2020
wangliang181230 added a commit to wangliang181230/seata that referenced this pull request Jul 1, 2020
@wangliang181230
Copy link
Contributor

wangliang181230 commented Jul 1, 2020

problem: When config in the file application.yml in the springboot project, the FileConfiguration can't get the configs seata.client.rm.saga-json-parser=jackson, seata.application-id, seata.tx-service-group.

Now in the #2838 ,fixed it.

q294881866 pushed a commit to jiumao-org/seata that referenced this pull request Jul 1, 2020
optimize ActionContextField

optimize ActionContextField
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/saga saga module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants