-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Saga support jackson json parser #2831
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2831 +/- ##
=============================================
+ Coverage 50.09% 50.13% +0.03%
- Complexity 2960 2973 +13
=============================================
Files 594 597 +3
Lines 19015 19071 +56
Branches 2291 2297 +6
=============================================
+ Hits 9526 9561 +35
- Misses 8545 8558 +13
- Partials 944 952 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.../seata-saga-engine-store/src/main/java/io/seata/saga/engine/config/DbStateMachineConfig.java
Show resolved
Hide resolved
Would it be better to Seata support jackson json parser? Not just SAGA mode. |
please resolve code conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for @wangliang1986
please resolve code conflicts |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.../seata-saga-engine-store/src/main/java/io/seata/saga/engine/config/DbStateMachineConfig.java
Outdated
Show resolved
Hide resolved
…ot项目的application.yml中配置该项时不生效。
problem: When config in the file Now in the #2838 ,fixed it. |
optimize ActionContextField optimize ActionContextField
Ⅰ. Describe what this PR did
Saga support jackson json parser
Ⅳ. Describe how to verify it
or