-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Saga support auto configuration in the spring boot project #2838
feature: Saga support auto configuration in the spring boot project #2838
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2838 +/- ##
=============================================
- Coverage 50.63% 50.58% -0.06%
- Complexity 3103 3111 +8
=============================================
Files 593 596 +3
Lines 19495 19543 +48
Branches 2406 2408 +2
=============================================
+ Hits 9872 9886 +14
- Misses 8633 8669 +36
+ Partials 990 988 -2
|
...oot-starter/src/main/java/io/seata/spring/boot/autoconfigure/SeataSagaAutoConfiguration.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ot项目的application.yml中配置该项时不生效。
…ts中,使FileConfiguration在springboot项目中,可以获取到相应的配置值。
…o-config # Conflicts: # seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/StarterConstants.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…o-config # Conflicts: # saga/seata-saga-engine/src/main/java/io/seata/saga/engine/impl/DefaultStateMachineConfig.java # script/client/conf/file.conf # script/client/spring/application.properties # script/client/spring/application.yml # script/config-center/config.txt # seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/SeataAutoConfiguration.java # seata-spring-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/StarterConstants.java
Codecov Report
@@ Coverage Diff @@
## develop #2838 +/- ##
=============================================
- Coverage 49.92% 49.86% -0.06%
- Complexity 3768 3776 +8
=============================================
Files 697 700 +3
Lines 23519 23567 +48
Branches 2909 2910 +1
=============================================
+ Hits 11742 11752 +10
- Misses 10594 10632 +38
Partials 1183 1183
|
…o-config # Conflicts: # seata-spring-autoconfigure/seata-spring-autoconfigure-client/src/main/resources/META-INF/additional-spring-configuration-metadata.json # seata-spring-autoconfigure/seata-spring-autoconfigure-core/src/main/java/io/seata/spring/boot/autoconfigure/SeataCorePropertiesAutoConfiguration.java # seata-spring-autoconfigure/seata-spring-autoconfigure-core/src/main/java/io/seata/spring/boot/autoconfigure/properties/SagaAsyncThreadPoolProperties.java
…o-config # Conflicts: # script/client/spring/application.properties # script/client/spring/application.yml # seata-spring-autoconfigure/seata-spring-autoconfigure-client/src/main/resources/META-INF/additional-spring-configuration-metadata.json # seata-spring-autoconfigure/seata-spring-autoconfigure-core/src/main/java/io/seata/spring/boot/autoconfigure/StarterConstants.java
# Conflicts: # script/client/conf/file.conf # script/client/spring/application.properties # script/client/spring/application.yml # seata-spring-autoconfigure/seata-spring-autoconfigure-client/src/main/java/io/seata/spring/boot/autoconfigure/SeataClientEnvironmentPostProcessor.java # seata-spring-autoconfigure/seata-spring-autoconfigure-client/src/main/resources/META-INF/additional-spring-configuration-metadata.json # seata-spring-autoconfigure/seata-spring-autoconfigure-core/src/main/java/io/seata/spring/boot/autoconfigure/StarterConstants.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
feature: Saga support auto configuration in the spring boot project
从PR #2551 中拆分出来的。
此PR实现的功能:
在springboot项目中:
另外添加了是否允许自动加载resources的配置项。主要用于dev环境下配置为false,不解析resources属性,加快项目启动速度。
Ⅱ. Does this pull request fix one issue?
fixes #3273
fixes #4051
fixes #3509
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews