feature: add antlr for mysql sqlparser #2933

springlayer · 2020-07-27T09:56:17Z

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-commenter · 2020-07-27T10:11:34Z

Codecov Report

Merging #2933 into develop will increase coverage by 0.44%.
The diff coverage is 72.38%.

@@              Coverage Diff              @@
##             develop    #2933      +/-   ##
=============================================
+ Coverage      50.57%   51.01%   +0.44%     
- Complexity      3105     3184      +79     
=============================================
  Files            599      615      +16     
  Lines          19510    19912     +402     
  Branches        2406     2433      +27     
=============================================
+ Hits            9868    10159     +291     
- Misses          8650     8748      +98     
- Partials         992     1005      +13

Impacted Files	Coverage Δ	Complexity Δ
...parser/antlr/mysql/AntlrMySQLDeleteRecognizer.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...parser/antlr/mysql/AntlrMySQLInsertRecognizer.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...parser/antlr/mysql/AntlrMySQLUpdateRecognizer.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...rser/antlr/mysql/MySQLOperateRecognizerHolder.java	`40.00% <40.00%> (ø)`	`2.00 <2.00> (?)`
...arser/antlr/SQLOperateRecognizerHolderFactory.java	`57.14% <57.14%> (ø)`	`2.00 <2.00> (?)`
...parser/antlr/mysql/AntlrMySQLSelectRecognizer.java	`62.50% <62.50%> (ø)`	`1.00 <1.00> (?)`
...arser/antlr/mysql/AntlrMySQLRecognizerFactory.java	`66.66% <66.66%> (ø)`	`3.00 <3.00> (?)`
...er/antlr/mysql/stream/ANTLRNoCaseStringStream.java	`83.33% <83.33%> (ø)`	`3.00 <3.00> (?)`
...ser/antlr/AntlrDelegatingSQLRecognizerFactory.java	`84.61% <84.61%> (ø)`	`3.00 <3.00> (?)`
...a/io/seata/sqlparser/antlr/mysql/MySqlContext.java	`87.09% <87.09%> (ø)`	`30.00 <30.00> (?)`
... and 22 more

sqlparser/seata-sqlparser-antlr/pom.xml

jsbxyyx · 2020-08-05T10:36:49Z

has code not committed.

...sqlparser-antlr/src/main/java/io/seata/sqlparser/antlr/mysql/AntlrMySQLInsertRecognizer.java

...sqlparser-antlr/src/main/java/io/seata/sqlparser/antlr/mysql/AntlrMySQLSelectRecognizer.java

...sqlparser-antlr/src/main/java/io/seata/sqlparser/antlr/mysql/AntlrMySQLUpdateRecognizer.java

...sqlparser-antlr/src/main/java/io/seata/sqlparser/antlr/mysql/AntlrMySQLDeleteRecognizer.java

…analysis

...sqlparser-antlr/src/main/java/io/seata/sqlparser/antlr/mysql/AntlrMySQLInsertRecognizer.java

…arsing spaces, add new SQL alias parsing methods, and optimize some codes.

codecov-io · 2020-10-23T04:10:39Z

Codecov Report

Merging #2933 (a78670a) into develop (fa3791e) will increase coverage by 0.38%.
The diff coverage is 72.61%.

@@              Coverage Diff              @@
##             develop    #2933      +/-   ##
=============================================
+ Coverage      51.58%   51.96%   +0.38%     
- Complexity      3401     3479      +78     
=============================================
  Files            621      637      +16     
  Lines          20655    21053     +398     
  Branches        2579     2606      +27     
=============================================
+ Hits           10655    10941     +286     
- Misses          8933     9032      +99     
- Partials        1067     1080      +13

Impacted Files	Coverage Δ	Complexity Δ
...parser/antlr/mysql/AntlrMySQLDeleteRecognizer.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...parser/antlr/mysql/AntlrMySQLInsertRecognizer.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...parser/antlr/mysql/AntlrMySQLUpdateRecognizer.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...rser/antlr/mysql/MySQLOperateRecognizerHolder.java	`40.00% <40.00%> (ø)`	`2.00 <2.00> (?)`
...parser/antlr/mysql/AntlrMySQLSelectRecognizer.java	`62.50% <62.50%> (ø)`	`1.00 <1.00> (?)`
...arser/antlr/SQLOperateRecognizerHolderFactory.java	`66.66% <66.66%> (ø)`	`2.00 <2.00> (?)`
...arser/antlr/mysql/AntlrMySQLRecognizerFactory.java	`66.66% <66.66%> (ø)`	`3.00 <3.00> (?)`
...er/antlr/mysql/stream/ANTLRNoCaseStringStream.java	`83.33% <83.33%> (ø)`	`3.00 <3.00> (?)`
...ser/antlr/AntlrDelegatingSQLRecognizerFactory.java	`84.61% <84.61%> (ø)`	`3.00 <3.00> (?)`
...a/io/seata/sqlparser/antlr/mysql/MySqlContext.java	`87.09% <87.09%> (ø)`	`30.00 <30.00> (?)`
... and 23 more

bom/pom.xml

l81893521 · 2020-11-09T07:19:13Z

pom.xml

@@ -337,7 +340,8 @@
                                <phase>validate</phase>
                                <configuration>
                                    <configLocation>${user.dir}/style/seata_checkstyle.xml</configLocation>
-                                    <suppressionsLocation>${user.dir}/style/seata_suppressions.xml</suppressionsLocation>
+                                    <suppressionsLocation>${user.dir}/style/seata_suppressions.xml


Please revert here.

pom space indentation has been processed

l81893521 · 2020-11-09T07:22:58Z

pom.xml

@@ -368,7 +372,8 @@
                <artifactId>protobuf-maven-plugin</artifactId>
                <version>${protobuf-maven-plugin.version}</version>
                <configuration>
-                    <protoSourceRoot>${project.basedir}/src/main/resources/protobuf/io/seata/protocol/transcation/</protoSourceRoot>
+                    <protoSourceRoot>${project.basedir}/src/main/resources/protobuf/io/seata/protocol/transcation/


Please reset here.

pom space indentation has been processed

l81893521 · 2020-11-09T07:46:36Z

...qlparser-antlr/src/main/java/io/seata/sqlparser/antlr/SQLOperateRecognizerHolderFactory.java

+     * @return the SQLOperateRecognizer
+     */
+    public static SQLOperateRecognizerHolder getSQLRecognizerHolder(String dbType) {
+        if (RECOGNIZER_HOLDER_MAP.get(dbType) != null) {


EnhancedServiceLoader already handle singleton, you can check SQLOperateRecognizerHolderFactory in druild.

already processed

This reverts commit 3c004e8

slievrly

LGTM

l81893521

LGTM

add antlr on mysql sqlparser

a3ed076

slievrly reviewed Jul 28, 2020

View reviewed changes

sqlparser/seata-sqlparser-antlr/pom.xml Outdated Show resolved Hide resolved

Merge branch 'develop' into develop

6555e81

springlayer changed the title ~~add antlr on mysql sqlparser~~ feature: add antlr on mysql sqlparser Jul 28, 2020

funky-eyes added the first-time contributor first-time contributor label Jul 28, 2020

funky-eyes and others added 2 commits August 4, 2020 17:26

Merge branch 'develop' into develop

580af0e

Merge branch 'develop' into develop

856b129

springlayer and others added 8 commits August 6, 2020 11:06

refactor: add sql parser type druid as constant

f7526cd

refactor: modify the name of seata-sqlparser-antlr pom

294a5c0

refactor: add antlr about mysql add, select, delete syntax analysis

6285fcb

refactor: modify antlr about mysql query syntax lexical analysis

701d09c

Merge branch 'develop' into develop

a97acb2

refactor: modified on antlr4 dependency management

e23c348

refactor: add antlr about mysql add, select, delete syntax analysis

da9f500

refactor: delete comment code and modify comment description

a68cb4d

jsbxyyx reviewed Aug 26, 2020

View reviewed changes

l81893521 reviewed Aug 27, 2020

View reviewed changes

...sqlparser-antlr/src/main/java/io/seata/sqlparser/antlr/mysql/AntlrMySQLDeleteRecognizer.java Outdated Show resolved Hide resolved

springlayer and others added 3 commits August 27, 2020 20:35

refactor: modify antlr about mysql add, query, modify, delete syntax …

2bd6cad

…analysis

refactor: add antlr about mysql add, select, delete syntax analysis

7714b67

Merge branch 'develop' into develop

8c36313

l81893521 reviewed Sep 3, 2020

View reviewed changes

...sqlparser-antlr/src/main/java/io/seata/sqlparser/antlr/mysql/AntlrMySQLInsertRecognizer.java Outdated Show resolved Hide resolved

springlayer added 2 commits September 3, 2020 10:01

refactor: modified AntlrMySQLInsterRecognizer about p3c specification

dcd788f

feature: modified AntlrMySQLInsterRecognizer about p3c specification

8c75eb3

springlayer closed this Sep 3, 2020

springlayer reopened this Sep 3, 2020

springlayer and others added 3 commits September 3, 2020 10:52

feature: modified AntlrMySQLInsterRecognizer about p3c specification

7d42def

feature: modified AntlrMySQLInsterRecognizer about p3c specification

68d6417

Merge branch 'develop' into develop

45064d6

funky-eyes and others added 6 commits September 14, 2020 23:20

Merge branch 'develop' into develop

3edb86d

feature: use antlr native lexical files to deal with the problem of p…

caa2a45

…arsing spaces, add new SQL alias parsing methods, and optimize some codes.

feature: use antlr native lexical files to deal with the problem of p…

e40e447

…arsing spaces, add new SQL alias parsing methods, and optimize some codes.

Merge branch 'develop' into develop

6275030

SqlParserType conflict resolution

dc57f0e

feature: use antlr native lexical files to deal with the problem of p…

d081b16

…arsing spaces, add new SQL alias parsing methods, and optimize some codes.

Merge branch 'develop' into develop

56786c6

l81893521 reviewed Nov 9, 2020

View reviewed changes

bom/pom.xml Outdated Show resolved Hide resolved

l81893521 reviewed Nov 9, 2020

View reviewed changes

springlayer added 6 commits November 9, 2020 17:32

feature: modify druid version

ced1a41

feature: handle pom space indentation

bc4f830

feature: modify SQLOperateRecognizerHolderFactory to handle singleton

cf88b6b

feature: modify TransactionPropagationInterceptor name

3c004e8

Revert "feature: modify TransactionPropagationInterceptor name"

7aa1754

This reverts commit 3c004e8

modify TransactionPropagationInterceptor name

ee3083a

slievrly closed this Jan 6, 2021

slievrly reopened this Jan 6, 2021

springlayer and others added 4 commits January 6, 2021 22:42

feature:modify SQLOperateRecognizerHolderFactory class indentation.

e9d14e8

feature: modify SQLOperateRecognizerHolderFactory class indentation.

2e3aa1c

Merge branch 'develop' into develop

42307d7

feature: add checkstyle-plugin

a78670a

slievrly approved these changes Feb 19, 2021

View reviewed changes

l81893521 approved these changes Feb 19, 2021

View reviewed changes

slievrly changed the title ~~feature: add antlr on mysql sqlparser~~ feature: add antlr for mysql sqlparser Feb 19, 2021

slievrly merged commit 546d342 into apache:develop Feb 19, 2021

slievrly added this to the 1.5.0 milestone Feb 21, 2021

slievrly mentioned this pull request Apr 22, 2021

optimize:register the participating companies and pull request information #3637

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: add antlr for mysql sqlparser #2933

feature: add antlr for mysql sqlparser #2933

springlayer commented Jul 27, 2020

codecov-commenter commented Jul 27, 2020 •

edited

jsbxyyx commented Aug 5, 2020

codecov-io commented Oct 23, 2020 •

edited

l81893521 Nov 9, 2020

springlayer Nov 9, 2020

l81893521 Nov 9, 2020

springlayer Nov 9, 2020

l81893521 Nov 9, 2020

springlayer Nov 9, 2020

slievrly left a comment

l81893521 left a comment

feature: add antlr for mysql sqlparser #2933

feature: add antlr for mysql sqlparser #2933

Conversation

springlayer commented Jul 27, 2020

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-commenter commented Jul 27, 2020 • edited

Codecov Report

jsbxyyx commented Aug 5, 2020

codecov-io commented Oct 23, 2020 • edited

Codecov Report

l81893521 Nov 9, 2020

Choose a reason for hiding this comment

springlayer Nov 9, 2020

Choose a reason for hiding this comment

l81893521 Nov 9, 2020

Choose a reason for hiding this comment

springlayer Nov 9, 2020

Choose a reason for hiding this comment

l81893521 Nov 9, 2020

Choose a reason for hiding this comment

springlayer Nov 9, 2020

Choose a reason for hiding this comment

slievrly left a comment

Choose a reason for hiding this comment

l81893521 left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jul 27, 2020 •

edited

codecov-io commented Oct 23, 2020 •

edited