-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix the problem of unit test #3110
Conversation
release 0.5.2
Release 0.6.1
release 0.7.1
release 0.8.0
[release] release 1.0.0
release 1.2.0
The CI failed .Please check .
|
mvn clean install -DskipTests=false -Dcheckstyle.skip=false -Dlicense.skip=false please use this command to test locally |
test/src/test/java/io/seata/saga/engine/db/StateMachineDBTests.java
Outdated
Show resolved
Hide resolved
https://github.com/seata/seata/blob/772d55d912ffd03c0c8feb5e1670144b5530636c/server/src/main/java/io/seata/server/coordinator/AbstractCore.java#L115-L123
|
[release]: release for 1.4.0
请解决代码冲突 |
# Conflicts: # test/src/test/java/io/seata/saga/engine/db/AbstractServerTest.java
Codecov Report
@@ Coverage Diff @@
## develop #3110 +/- ##
=============================================
- Coverage 49.59% 49.58% -0.01%
+ Complexity 3730 3729 -1
=============================================
Files 693 693
Lines 23402 23402
Branches 2899 2899
=============================================
- Hits 11606 11604 -2
- Misses 10631 10632 +1
- Partials 1165 1166 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix the problem of unit test
Ⅱ. Does this pull request fix one issue?
fixes #3109
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews